Main #2
Merged
Main #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Consolidate import statements across multiple files for clarity. * Remove redundant blank lines to improve readability. * Adjust type annotations to maintain consistency. * Enhance the structure of the codebase by ensuring proper ordering of imports. * Update test files to reflect changes in import structure and improve organization.
There was a problem hiding this comment.
Pull request overview
This PR applies comprehensive code formatting and linting improvements across the codebase, including alphabetically sorted imports, trailing whitespace removal, YAML indentation fixes, and updated tooling configuration. The changes correct several critical typos in the module name (permisio → permissio) that were preventing proper type checking and test coverage.
Key changes:
- Fixed critical typos in module references across configuration files
- Alphabetically sorted imports in all Python files following standard grouping
- Improved type hints (e.g.,
callable→Callable[[Dict[str, Any]], T]) - Added Python 3.9 compatibility settings to ruff configuration
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Fixed typos in mypy and ruff config, added Python 3.9 compatibility rules |
| .github/workflows/ci.yml | Fixed typos and normalized YAML indentation to 2 spaces |
| tests/test_sdk.py | Alphabetically sorted imports, removed trailing whitespace |
| permissio/sync.py | Alphabetically sorted imports |
| permissio/models/*.py | Alphabetically sorted imports across all model files |
| permissio/api/*.py | Alphabetically sorted imports across all API client files |
| permissio/client.py | Alphabetically sorted imports, improved set comprehension syntax |
| permissio/config.py | Alphabetically sorted imports, added blank line |
| permissio/errors.py | Alphabetically sorted imports |
| permissio/enforcement/*.py | Alphabetically sorted imports |
| permissio/init.py | Alphabetically sorted imports |
| examples/*.py | Alphabetically sorted imports, removed trailing whitespace, improved exception handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.