Skip to content

fix: CI workflow fixes for fork-check permissions and only_changed#118

Merged
k-rister merged 2 commits into
masterfrom
fix-ci-workflows
May 20, 2026
Merged

fix: CI workflow fixes for fork-check permissions and only_changed#118
k-rister merged 2 commits into
masterfrom
fix-ci-workflows

Conversation

@k-rister
Copy link
Copy Markdown
Contributor

Summary

CI workflow fixes:

  1. fork-check.yaml: Add permissions block (issues: write, pull-requests: write) and broaden event types to include synchronize and edited.

Test plan

  • Fork-check: verified working on bench-trafficgen#106
  • only_modified: verify CI runs correctly

🤖 Generated with Claude Code

The fork-check workflow needs issues:write and pull-requests:write
permissions to comment on and close fork PRs. Without these, the
GITHUB_TOKEN for pull_request_target events from forks only has
read permissions, causing the API calls to fail with 403.

Also add synchronize and edited event types so the workflow triggers
on existing fork PRs when commits are pushed or the PR is edited,
not just on initial open/reopen.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@k-rister k-rister self-assigned this May 20, 2026
@k-rister k-rister requested a review from a team May 20, 2026 14:48
@project-crucible-tracking project-crucible-tracking Bot moved this from Queued to In Progress in Crucible Tracking May 20, 2026
atheurer
atheurer previously approved these changes May 20, 2026
The fork-check.yaml entry had extra leading spaces causing it to not
be recognized as part of the changed-files exclusion list, triggering
unnecessary full CI runs when only fork-check.yaml was modified.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@k-rister k-rister merged commit 39c8346 into master May 20, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Crucible Tracking May 20, 2026
@k-rister k-rister deleted the fix-ci-workflows branch May 20, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants