Open
Conversation
Changes to be committed: modified: cmd/postgres_exporter/postgres_exporter.go modified: cmd/postgres_exporter/queries.go Adding vacuum monitoring and adjusting pg_stat_activity for better troubleshooting.
BupycHuk
approved these changes
Nov 14, 2023
BupycHuk
changed the title
BupycHuk
reviewed
Nov 14, 2023
| ( | ||
| SELECT | ||
| datname, | ||
| pid, |
There was a problem hiding this comment.
as far as I remember this pid value creates high cardinality and brings a problem with bad performance and high disk space usage.
There was a problem hiding this comment.
@BupycHuk Are we going to try it and if needed discart it based on QAs results? Or discart it before merge?
There was a problem hiding this comment.
let's discard it before merge, because we've faced this problem already in past
JiriCtvrtka
approved these changes
Dec 6, 2023
|
@heniek Could you discard changes related to PID? Thank you. |
Author
|
Hey, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to be committed:
modified: cmd/postgres_exporter/postgres_exporter.go
modified: cmd/postgres_exporter/queries.go
PMM-12650 Adding vacuum monitoring and adjusting pg_stat_activity for better troubleshooting.