fix: Enable paralleltest linter rule #4883
Open
+1,463
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the paralleltest linter rule in .golangci.yml and add t.Parallel() calls to all test functions and subtests to support parallel test execution. This change: - Removes paralleltest from the disabled linters list in .golangci.yml - Adds t.Parallel() to 180+ test files across the codebase - Removes unused //nolint:paralleltest directives - Fixes benchmark functions that incorrectly had b.Parallel() added Signed-off-by: majiayu000 <1835304752@qq.com>
Fix malformed t.Parallel() calls that were split across multiple lines, causing gci linter errors. Signed-off-by: majiayu000 <1835304752@qq.com>
majiayu000
requested review from
ademidoff and
maxkondr
and removed request for
a team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #4883 +/- ##
=======================================
Coverage 45.93% 45.93%
=======================================
Files 364 364
Lines 37880 37880
=======================================
Hits 17399 17399
Misses 18805 18805
Partials 1676 1676
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2342
Changes