Skip to content

K8SPG-911 cleanup properl the pg tde e2e test resources - #1720

Open
gkech wants to merge 2 commits into
mainfrom
K8SPG-911-e2e-test-pgtde-cleanup
Open

K8SPG-911 cleanup properl the pg tde e2e test resources#1720
gkech wants to merge 2 commits into
mainfrom
K8SPG-911-e2e-test-pgtde-cleanup

Conversation

@gkech

@gkech gkech commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

CHANGE DESCRIPTION

Problem:
The pg tde e2e test leaves resources available on the k8s cluster after its completion that it shouldn't. With this pr we are properly cleaning up these resources. This is also important for local execution, especially on consecutive runs on the same k8s cluster.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@egegunes egegunes added this to the v3.1.0 milestone Aug 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the pg-tde E2E test teardown so that Vault-related resources (Helm release, namespace, and CSR) are removed after the suite completes, reducing leftover cluster state that can break consecutive local runs.

Changes:

  • Add explicit Vault Helm uninstall, namespace deletion, and CSR deletion to the pg-tde cleanup step.
  • Make the Vault CSR name deterministic (vault-csr-${name}) and delete any existing CSR before recreating it.
  • Increase the cleanup step timeout to accommodate the extra teardown work.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
e2e-tests/tests/pg-tde/99-remove-cluster-gracefully.yaml Ensures Vault Helm release, namespace, and CSR are cleaned up at the end of the pg-tde E2E suite; increases timeout.
e2e-tests/functions Uses a predictable Vault CSR name and proactively deletes any existing CSR before creation to avoid collisions across reruns.

@JNKPercona

Copy link
Copy Markdown
Collaborator
Test Name Result Time
backup-enable-disable passed 00:00:00
builtin-extensions passed 00:00:00
custom-extensions passed 00:00:00
cert-manager-tls passed 00:00:00
cert-management-policy failure 00:05:18
custom-envs passed 00:00:00
custom-tls passed 00:00:00
database-init-sql passed 00:00:00
demand-backup passed 00:00:00
demand-backup-offline-snapshot passed 00:00:00
dynamic-configuration passed 00:00:00
extra-volumes passed 00:00:00
finalizers passed 00:00:00
init-deploy passed 00:00:00
huge-pages passed 00:00:00
major-upgrade-14-to-15 passed 00:00:00
major-upgrade-15-to-16 passed 00:00:00
major-upgrade-16-to-17 passed 00:00:00
major-upgrade-17-to-18 passed 00:00:00
ldap passed 00:00:00
ldap-tls passed 00:00:00
logcollection passed 00:00:00
monitoring passed 00:10:02
one-pod passed 00:00:00
repo-host-autogrow passed 00:00:00
operator-self-healing passed 00:00:00
pgbouncer-mtls passed 00:00:00
pg-tde passed 00:00:00
pitr passed 00:00:00
scaling passed 00:00:00
scheduled-backup passed 00:00:00
self-healing passed 00:00:00
sidecars passed 00:00:00
standby-pgbackrest passed 00:00:00
standby-streaming passed 00:00:00
start-from-backup passed 00:00:00
tablespaces passed 00:00:00
telemetry-transfer passed 00:00:00
upgrade-consistency passed 00:00:00
upgrade-minor passed 00:00:00
users passed 00:00:00
migration-from-crunchy-standby passed 00:00:00
migration-from-crunchy-pv passed 00:00:00
migration-from-crunchy-backup-restore passed 00:19:15
Summary Value
Tests Run 44/44
Job Duration 00:44:42
Total Test Time 00:34:35

commit: ebff9e9
image: perconalab/percona-postgresql-operator:PR-1720-ebff9e9f2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants