K8SPG-911 cleanup properl the pg tde e2e test resources - #1720
Open
gkech wants to merge 2 commits into
Open
Conversation
gkech
marked this pull request as ready for review
August 3, 2026 15:13
gkech
requested review from
DhruthiKV,
egegunes,
eleo007,
jvpasinatto,
mayankshah1607,
nmarukovich,
oksana-grishchenko,
pooknull and
valmiranogueira
as code owners
August 3, 2026 15:13
egegunes
approved these changes
Aug 4, 2026
mayankshah1607
approved these changes
Aug 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the pg-tde E2E test teardown so that Vault-related resources (Helm release, namespace, and CSR) are removed after the suite completes, reducing leftover cluster state that can break consecutive local runs.
Changes:
- Add explicit Vault Helm uninstall, namespace deletion, and CSR deletion to the pg-tde cleanup step.
- Make the Vault CSR name deterministic (
vault-csr-${name}) and delete any existing CSR before recreating it. - Increase the cleanup step timeout to accommodate the extra teardown work.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e-tests/tests/pg-tde/99-remove-cluster-gracefully.yaml | Ensures Vault Helm release, namespace, and CSR are cleaned up at the end of the pg-tde E2E suite; increases timeout. |
| e2e-tests/functions | Uses a predictable Vault CSR name and proactively deletes any existing CSR before creation to avoid collisions across reruns. |
Collaborator
commit: ebff9e9 |
pooknull
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
The pg tde e2e test leaves resources available on the k8s cluster after its completion that it shouldn't. With this pr we are properly cleaning up these resources. This is also important for local execution, especially on consecutive runs on the same k8s cluster.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability