build: drop vendored Playground builds for released @wp-playground/cli#101
Merged
Conversation
The vendored @wp-playground/cli + @php-wasm/universal tarballs (a build of WordPress/wordpress-playground#3494) worked around a worker-pool bug that returned PHP workers to the pool before their streamed response finished, causing intermittent 500s under concurrent e2e requests. That bug was fixed upstream (WordPress/wordpress-playground#3553) and shipped in the 3.1.2x line, so depend on the released package instead. - @wp-playground/cli: file:./vendor/...-pr3494.tgz -> ^3.1.36 - drop the @php-wasm/universal file: override (now resolves transitively) - remove the vendor/ tarballs - run the e2e Playground server with --workers=auto Verified: e2e 23/23 on 4 workers (no 5xx), php 140/140.
There was a problem hiding this comment.
Pull request overview
This PR removes vendored Playground CLI tarballs and switches the project to consume the released @wp-playground/cli@^3.1.36, aligning the e2e environment with upstream fixes to the worker pool behavior.
Changes:
- Update
@wp-playground/clidependency from a vendoredfile:tarball to^3.1.36and drop the@php-wasm/universalvendored override. - Adjust e2e pretest build steps in
package.json. - Run the Playground e2e server with
--workers=auto.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/e2e/helpers/playground.ts |
Adds --workers=auto when starting the Playground server for e2e runs. |
package.json |
Switches to released @wp-playground/cli, removes a vendored override, and updates the pretest:e2e build command. |
✅ Coverage Report — plugin-php
✅ Coverage Report — plugin-typescript
✅ Coverage Report — typescript
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drops the vendored
@wp-playground/cli+@php-wasm/universaltarballs (a build of WordPress/wordpress-playground#3494) and depends on released@wp-playground/cli@^3.1.36instead.Why
The vendored build worked around a Playground worker-pool bug: the object-pool proxy returned a PHP worker to the free list before its streamed response finished, so concurrent e2e requests landed on a mid-response worker and WordPress returned 500. That PR was closed unmerged; the issue was fixed upstream by WordPress/wordpress-playground#3553 ("Hold pooled workers until streamed responses finish"), shipped in the 3.1.2x line (latest 3.1.36).
Changes
@wp-playground/cli:file:./vendor/...-pr3494.tgz->^3.1.36@php-wasm/universalfile:override (now resolves transitively to 3.1.36); kept the unrelatede2e-test-utils-playwright->@types/nodeoverridevendor/tarballs--workers=autoVerification
Note
Unrelated to this change: the Playground CLI's native
fs-ext-extra-prebuiltdependency has no Node 26 prebuilt yet (binaries stop at node-25), so verify locally on Node <= 25. CI is unaffected — it runs e2e + php on Node 22.