fix(watchdog): stop alerting on content the mirror is never meant to publish - #2541
Conversation
…publish The watchdog's first live run cried wolf and would have done so every 15 minutes forever. It compared mono's latest commit touching `content/` against the sha stamped in peanut-content's "mirror: sync from mono@<sha>" tip. But the mirror rsyncs `content/` with `--exclude='_system/'` (plus `_system/generated/` separately), so a commit touching only `content/_system/**` is correctly never published. The comparison read that as the mirror being stuck. d9a33de — a docs edit to content/_system/ARCHITECTURE.md — tripped it within minutes of merge. The stamp can't answer "is the mirror healthy" because it only ever names commits that happened to touch mirrored paths. Ask something that has a real answer: did the mirror's last completed run succeed? A run that published nothing is healthy; one that errored is not. A broken mirror also skips the grace period, since it will not fix itself. Verified against the same live state that produced the false alarm: now reports CURRENT and stays silent.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code-analysis diffPainscore total: 6284.43 → 6284.43 (0) |
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
Urgent-ish: the watchdog from #2538 is currently false-alarming to Discord every 15 minutes. This stops it.
What happened
Its first live run cried wolf:
d9a33deis a docs edit tocontent/_system/ARCHITECTURE.md. The mirror rsyncscontent/with--exclude='_system/'(plus_system/generated/separately), so that commit is correctly never published — but the hop-1 check compared mono's latestcontent/**commit against themirror: sync from mono@<sha>stamp and read it as a stuck mirror. It would repeat every 15 min forever.The fix
The stamp can't answer "is the mirror healthy" — it only ever names commits that happened to touch mirrored paths. Ask something with a real answer instead: did the mirror's last completed run succeed? A run that published nothing is healthy; one that errored is not. A broken mirror also now skips the 45-min grace period, since it won't fix itself.
Hop 2→3 (
LIVE != TIP) is unchanged and still catches everything downstream.QA
Dry-run against the exact live state that produced the false alarm:
YAML parses,
bash -nclean, prettier clean.Note on the false positive
The watchdog itself behaved correctly end to end — detected a divergence, posted to Discord, failed the run loudly. The bug was in what it compared, not in the alerting. Worth knowing the alert path is proven working.