Skip to content

Revert "feat(card): show settlement adjustments + next-deposit deduction banner"#2497

Open
abalinda wants to merge 1 commit into
devfrom
revert-2459-feat/card-settlement-adjust-visibility
Open

Revert "feat(card): show settlement adjustments + next-deposit deduction banner"#2497
abalinda wants to merge 1 commit into
devfrom
revert-2459-feat/card-settlement-adjust-visibility

Conversation

@abalinda

@abalinda abalinda commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Reverts #2459

merger previous PR by missclick

Copilot AI review requested due to automatic review settings July 23, 2026 17:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
peanut-wallet Ready Ready Preview, Comment Jul 23, 2026 5:52pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 38707c95-2215-4c95-8711-db75a0f4aac1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-2459-feat/card-settlement-adjust-visibility

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Code-analysis diff

Painscore total: 6239.8 → 6233.2 (-6.6)
Findings: -3 net (+22 new, -25 resolved)

🆕 New findings (22)

  • critical complexity — src/components/TransactionDetails/TransactionDetailsReceipt.tsx — CC 160, MI 52.89, SLOC 352
  • critical method-complexity — src/components/TransactionDetails/TransactionDetailsReceipt.tsx:74 — CC 108 SLOC 170
  • critical complexity — src/components/TransactionDetails/provider-rows/CardPaymentRows.tsx — CC 52, MI 51.55, SLOC 128
  • critical complexity — src/components/TransactionDetails/TransactionCard.tsx — CC 52, MI 50.35, SLOC 164
  • high hotspot — src/components/TransactionDetails/TransactionDetailsReceipt.tsx — 41 commits, +475/-1080 lines since 6 months ago
  • high method-complexity — src/components/TransactionDetails/TransactionCard.tsx:65 — CC 40 SLOC 89
  • medium high-mdd — src/components/TransactionDetails/TransactionDetailsReceipt.tsx:74 — TransactionDetailsReceipt: MDD 176.5 (uses across many lines from declarations)
  • medium high-dlt — src/components/TransactionDetails/TransactionDetailsReceipt.tsx:74 — TransactionDetailsReceipt: DLT 81 (calls 81 distinct functions — high context load)
  • medium high-mdd — src/components/TransactionDetails/provider-rows/CardPaymentRows.tsx:109 — CardPaymentRows: MDD 62.9 (uses across many lines from declarations)
  • medium high-mdd — src/components/TransactionDetails/TransactionCard.tsx:65 — TransactionCard: MDD 55.2 (uses across many lines from declarations)
  • medium high-mdd — src/components/Card/YourCardScreen.tsx:29 — YourCardScreen: MDD 47.6 (uses across many lines from declarations)
  • medium hotspot — src/components/TransactionDetails/TransactionCard.tsx — 29 commits, +222/-161 lines since 6 months ago
  • medium complexity — src/utils/balance.utils.ts — CC 24, MI 62.32, SLOC 73
  • medium complexity — src/components/Card/YourCardScreen.tsx — CC 22, MI 63.55, SLOC 52
  • medium method-complexity — src/components/TransactionDetails/provider-rows/CardPaymentRows.tsx:109 — CardPaymentRows CC 21 SLOC 71
  • medium complexity — src/components/TransactionDetails/transaction-details.utils.ts — CC 17, MI 64.41, SLOC 50
  • low high-dlt — src/components/TransactionDetails/TransactionCard.tsx:65 — TransactionCard: DLT 28 (calls 28 distinct functions — high context load)
  • low high-dlt — src/components/Card/YourCardScreen.tsx:29 — YourCardScreen: DLT 16 (calls 16 distinct functions — high context load)
  • low structural-dup — components/Send/link/views/Success.link.send.view.tsx:102 — 14 duplicate lines / 73 tokens with components/TransactionDetails/TransactionDetailsReceipt.tsx:830
  • low missing-return-type — src/components/TransactionDetails/provider-rows/CardPaymentRows.tsx:109 — CardPaymentRows: exported fn missing return type annotation

…and 2 more.

✅ Resolved (25)

  • src/components/TransactionDetails/TransactionDetailsReceipt.tsx — CC 161, MI 52.87, SLOC 352
  • src/components/TransactionDetails/TransactionDetailsReceipt.tsx:75 — CC 109 SLOC 170
  • src/components/TransactionDetails/TransactionCard.tsx — CC 55, MI 50.06, SLOC 167
  • src/components/TransactionDetails/provider-rows/CardPaymentRows.tsx — CC 52, MI 49.27, SLOC 131
  • src/components/TransactionDetails/TransactionCard.tsx:65 — CC 43 SLOC 92
  • src/components/TransactionDetails/TransactionDetailsReceipt.tsx — 40 commits, +475/-1073 lines since 6 months ago
  • src/components/TransactionDetails/TransactionDetailsReceipt.tsx:75 — TransactionDetailsReceipt: MDD 177.7 (uses across many lines from declarations)
  • src/components/TransactionDetails/TransactionDetailsReceipt.tsx:75 — TransactionDetailsReceipt: DLT 81 (calls 81 distinct functions — high context load)
  • src/components/TransactionDetails/provider-rows/CardPaymentRows.tsx:101 — CardPaymentRows: MDD 61.1 (uses across many lines from declarations)
  • src/components/TransactionDetails/TransactionCard.tsx:65 — TransactionCard: MDD 59.7 (uses across many lines from declarations)
  • src/components/Card/YourCardScreen.tsx:30 — YourCardScreen: MDD 52.1 (uses across many lines from declarations)
  • src/components/TransactionDetails/TransactionCard.tsx — 28 commits, +222/-150 lines since 6 months ago
  • src/utils/balance.utils.ts — CC 28, MI 62.21, SLOC 80
  • src/components/TransactionDetails/provider-rows/CardPaymentRows.tsx:101 — CardPaymentRows CC 24 SLOC 81
  • src/components/Card/YourCardScreen.tsx — CC 23, MI 62.37, SLOC 55
  • src/components/TransactionDetails/transaction-details.utils.ts — CC 20, MI 64.2, SLOC 57
  • src/components/TransactionDetails/provider-rows/CardAdjustmentNotice.tsx — CC 7, MI 63.73, SLOC 16
  • src/components/TransactionDetails/TransactionCard.tsx:65 — TransactionCard: DLT 29 (calls 29 distinct functions — high context load)
  • src/components/Card/YourCardScreen.tsx:30 — YourCardScreen: DLT 18 (calls 18 distinct functions — high context load)
  • components/Send/link/views/Success.link.send.view.tsx:102 — 14 duplicate lines / 73 tokens with components/TransactionDetails/TransactionDetailsReceipt.tsx:837

…and 5 more.

📈 Painscore deltas (top movers)

File Before After Δ
src/components/TransactionDetails/provider-rows/CardAdjustmentNotice.tsx 6.0 0.0 -6.0

@github-actions

Copy link
Copy Markdown
Contributor

🧪 UI test report — ✅ all green

Suites

  • unit: 2017 ran, 0 failed, 0 skipped, 35.0s

📊 Coverage (unit)

metric %
statements 59.9%
branches 43.5%
functions 48.9%
lines 60.1%
⏱ 10 slowest test cases
time test
3.6s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › never places two stickers in heavy overlap (broad seed sweep)
1.4s src/utils/__tests__/demo-api.test.ts › isDemoMode() is false when not running under Capacitor
0.5s src/app/actions/__tests__/api-headers.test.ts › should include Content-Type in validateInviteCode
0.4s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › every sticker stays within canvas at any count
0.4s src/app/actions/__tests__/api-headers-extended.test.ts › should not include apiKey in validateInviteCode body
0.4s src/utils/__tests__/url.utils.test.ts › uses the public BASE_URL in Capacitor, not the localhost WebView origin
0.3s src/app/(mobile-ui)/withdraw/__tests__/withdraw-states.test.tsx › Bank withdrawal keeps the $1 minimum for sub-$1 amounts
0.2s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › keeps stickers off the username pill (final pass respects the keep-out)
0.2s src/utils/__tests__/demo-balance.test.ts › resetDemoBalance refills and restarts the TTL window
0.2s src/utils/__tests__/demo-balance.test.ts › auto-refills a stored balance that has no timestamp (legacy install)
📍 Inline annotations are in the **Unit test report** check above. Coverage artifact: `coverage-unit`. Generated by `.github/workflows/tests.yml`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants