docs(lexicon): align activation & analytics comments with new canonical definitions - #2468
docs(lexicon): align activation & analytics comments with new canonical definitions#24680xkkonrad wants to merge 1 commit into
Conversation
… definitions Activated is now >=1 SPEND transaction (card spend or QR spend on Mercado Pago/Pix) — computed backend-side on /users/me; the hook only consumes isActivated/activationMilestone, so this narrows semantics without code changes here. Also drops the banned "Churn" wording from the analytics section header, corrects the CARD_LAUNCH_CTA comment (Home Carousel CTA, not a banner), and replaces "cashback" with "rewards" in the CARD_PIONEER note. No event strings or identifiers renamed — PostHog history stays intact. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code-analysis diffPainscore total: 6232.6 → 6233.02 (+0.42) 🆕 New findings (5)
✅ Resolved (5)
|
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
What
Comment/doc-only pass bringing peanut-ui in line with the new canonical lexicon (Activated = ≥1 spend transaction: card spend — qualifying event = authorization — or QR spend on Mercado Pago/Pix; "churned"/"dormant" banned in favor of Inactive; rewards never count as transactions).
src/hooks/useActivationStatus.ts— JSDoc/comments updated to the spend-only Activated definition. No behavior change: the hook consumesisActivated/activatedAt/activationMilestonefrom the BE (/users/me), so the semantic narrowing lands via the parallel backend PR and everything gated on this hook (home carousel CTAs, rewards/referral gating) inherits it automatically. The'outbound'step id is kept (2 consumers) but documented as "make your first spend". Also fixed a stale fallback note — the code defaultsisActivatedtofalsewhen the BE omits it, nottrue.src/constants/analytics.consts.ts— comment-only: "Error / Churn" section header → "Error" (banned term);CARD_LAUNCH_CTA_*comment corrected from "banner" to Home Carousel CTA. No event string values renamed — PostHog history intact (incl.CLAIM_LINK_*).src/components/Badges/badge.utils.ts— CARD_PIONEER comment: "cashback" → "rewards".The
latam-cashback-inviteCTA id was intentionally left untouched (tracking continuity).Verification
tsc --noEmit: no errors in touched filesjest:ActivationCTAs.test.tsx+badge.utils.test.ts— 6/6 passCompanion change: quiz definitional update on #2465
🤖 Generated with Claude Code