Skip to content

fix(ci): grant permissions required by csharp-ci/scala-ci v2.4.0 - #7

Merged
monsieurleberre merged 1 commit into
mainfrom
fix/ci-grant-reusable-v2-permissions
Jul 17, 2026
Merged

fix(ci): grant permissions required by csharp-ci/scala-ci v2.4.0#7
monsieurleberre merged 1 commit into
mainfrom
fix/ci-grant-reusable-v2-permissions

Conversation

@monsieurleberre

Copy link
Copy Markdown
Contributor

One-line class of fix applied org-wide: the reusable workflows' new matrix-comment job (github-actions#36, shipped in 2.4.0 on the floating v2 tag) requests actions: read (+ uses pull-requests: write). A called workflow cannot request a permission its caller doesn't grant, and GitHub validates this statically at run creation — so every CI run in this repo since 2026-07-14 07:09Z ended in startup_failure before any job ran, on push and PR events alike.

This grants the missing scope(s) in the workflow-level permissions: block. Decision by the release owner: grant the read-only scope in all consumers and keep the sticky build-matrix comment feature, rather than revert it provider-side (see peacefulstudio/github-actions#37, closed).

Sibling fix verified live in daml-codegen-csharp-internal#637 (first CI run to start since the tag moved).

The reusable workflows' matrix-comment job (github-actions#36) requests actions:read and pull-requests:write; a called workflow cannot request a permission the caller does not grant, and GitHub validates this statically at run creation - every CI run since the floating v2 tag moved to 2.4.0 (2026-07-14) ended in startup_failure before any job ran.
@github-actions

Copy link
Copy Markdown
Contributor

C# coverage

Code Coverage

Package Line Rate Branch Rate Complexity Health
Canton.Ledger.Grpc.Client 97% 85% 302
Canton.Ledger.Kernel 100% 98% 70
Canton.Ledger.OpenTelemetry 100% 100% 1
Canton.Ledger.Pqs.Client 89% 80% 48
Daml.Runtime.Grpc 99% 99% 82
Summary 97% (1150 / 1190) 88% (423 / 478) 503

@github-actions

Copy link
Copy Markdown
Contributor

C# build matrix

shard result duration
macos-amd64 ✅ success 2m 10s
macos-arm64 ✅ success 54s
ubuntu-amd64 ✅ success 1m 13s
ubuntu-arm64 ✅ success 1m 05s
windows-amd64 ✅ success 2m 02s
windows-arm64 ✅ success 2m 08s

@monsieurleberre
monsieurleberre merged commit 2c7d410 into main Jul 17, 2026
14 checks passed
@monsieurleberre
monsieurleberre deleted the fix/ci-grant-reusable-v2-permissions branch July 17, 2026 05:57
monsieurleberre added a commit that referenced this pull request Jul 19, 2026
…ic CHANGELOG (#9)

The public CHANGELOG carried references that only resolve inside the private
repo and render as dead links or leak internal process artifacts to consumers:

- 118 internal `#issue` references (the one real public PR, #7, is kept)
- 35 `ADR NNNN` / `ADR-NNNN` citations and 2 `docs/adr/*.md` paths
- 33 internal audit finding ids (`F-NN`, `audit`, `audit sweep` source-tags)
- internal-promotion jargon ("promoted public-paths")
- one whole entry describing the internal promote-public-overlay leak-scan,
  which references an internal-only workflow and is meaningless to consumers

Prose was reworded where a removed reference was a grammatical subject so every
sentence still reads naturally; no technical content was changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant