Skip to content

Add veloc - #50

Merged
iole-bolognesi merged 18 commits into
pre_v5from
add_veloc
Oct 27, 2026
Merged

iole-bolognesi merged 18 commits into
pre_v5from
add_veloc

Conversation

@iole-bolognesi

Copy link
Copy Markdown
Contributor

Replace PR 49 with a branch without restrictions

@iole-bolognesi
iole-bolognesi marked this pull request as draft October 20, 2026 12:17
Comment thread debuntu/all/Dockerfile Resolved
Comment thread debuntu/mini/Dockerfile Resolved
Comment thread debuntu/all/Dockerfile Resolved
Comment thread debuntu/mini/Dockerfile Resolved
@iole-bolognesi
iole-bolognesi marked this pull request as ready for review October 22, 2026 17:51
@iole-bolognesi
iole-bolognesi requested a review from jbigot October 22, 2026 17:52
Comment thread debuntu/all/Dockerfile Resolved
Comment thread debuntu/mini/Dockerfile Resolved
Comment thread spack/2-spackbase/Dockerfile Resolved
Comment thread spack/3-baselibs/Dockerfile Resolved
Comment thread spack/4-mini/Dockerfile Resolved
Comment thread spack/5-all/Dockerfile Resolved
Comment thread spack/6-finalize/Dockerfile Resolved

@jbigot jbigot left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only extremely minor remarks. Good to go! Congrats on the nice work!

@jbigot

jbigot commented Oct 24, 2026

Copy link
Copy Markdown
Member

Also, adding something should make it v5. So I propose to not merge your branch in v4, but instead create pre_v5 on top of v4. Then #36 can be merged into it, and as soon as it is, we make that v5. You should be able to test the plugin against pre_v5 anyway by changing the tag in the tests of your branch.

If #36 isn't merged when the plugin is ready on PDI side, then we'll make it v5 anyway and #36 will be v6

@jbigot
jbigot changed the base branch from v4 to pre_v5 October 24, 2026 16:01

@jbigot jbigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot

@iole-bolognesi
iole-bolognesi merged commit 7cdca03 into pre_v5 Oct 27, 2026
@iole-bolognesi
iole-bolognesi deleted the add_veloc branch October 27, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants