Repository navigation
Rename the mock switch of the example PDI_EXAMPLE_USE_MOCK_PDI - #868
Merged
Merged
Conversation
jbigot
force-pushed
the
example_mock_pdi
branch
2 times, most recently
from
October 18, 2026 13:29
5bc0b66 to
cd98cb2
Compare
jmorice91
reviewed
Oct 21, 2026
jmorice91
left a comment
Contributor
There was a problem hiding this comment.
I suggest a little change in the variable name to improve the understanding and the reusing of the users.
When we are agree with the new name, this PR is ready to ship.
jbigot
force-pushed
the
example_mock_pdi
branch
from
October 30, 2026 12:00
cd98cb2 to
e1a7b73
Compare
Yushan-Wang
force-pushed
the
example_mock_pdi
branch
from
November 2, 2026 15:31
e1a7b73 to
6a641d9
Compare
Yushan-Wang
approved these changes
Nov 2, 2026
Yushan-Wang
force-pushed
the
example_mock_pdi
branch
4 times, most recently
from
November 3, 2026 09:50
d8d9414 to
2a25543
Compare
jbigot
force-pushed
the
example_mock_pdi
branch
from
November 3, 2026 10:40
2a25543 to
c88b735
Compare
Yushan-Wang
force-pushed
the
example_mock_pdi
branch
from
November 3, 2026 15:34
c88b735 to
f5059e6
Compare
jbigot
force-pushed
the
example_mock_pdi
branch
3 times, most recently
from
November 4, 2026 09:16
bc7bf51 to
946bfb2
Compare
DISABLE_PDI is a very generic a name for a cache variable: any project that adds the example, the distribution among them, may own a variable of that name. The switch that builds the example against the mock PDI is renamed PDI_EXAMPLE_USE_MOCK_PDI, after the project it belongs to, and the documentation that uses it as the model of a SubdirMock setup follows. Fix #785
Yushan-Wang
force-pushed
the
example_mock_pdi
branch
from
November 4, 2026 09:42
946bfb2 to
4575ad5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISABLE_PDI is a very generic a name for a cache variable: any project that adds the example, the distribution among them, may own a variable of that name. The switch that builds the example against the mock PDI is renamed PDI_EXAMPLE_USE_MOCK_PDI, after the project it belongs to, and the documentation that uses it as the model of a SubdirMock setup follows.
Fix #785
List of things to check before making a PR
Before merging your code, please check the following:
CONTRIBUTING.md;AUTHORSfile:AUTHORSfile;AUTHORSfile;Fix #issuekeyword to autoclose the issue when merged.