Skip to content

Use pyreadline3 instead of pyreadline#44

Closed
Andrej730 wants to merge 1 commit into
pdbpp:masterfrom
Andrej730:master
Closed

Use pyreadline3 instead of pyreadline#44
Andrej730 wants to merge 1 commit into
pdbpp:masterfrom
Andrej730:master

Conversation

@Andrej730

@Andrej730 Andrej730 commented Feb 7, 2023

Copy link
Copy Markdown

Based on #41

Let's replace abandonded pyreadline with pyreadline3. As said in #41 it will fix #36 and #37.

@athrvvvv @blueyed

@athrvvvv athrvvvv left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Andrej730

Andrej730 commented Mar 7, 2023

Copy link
Copy Markdown
Author

@athrvvvv @blueyed any changes still needed for merge?

@athrvvvv

athrvvvv commented Mar 7, 2023

Copy link
Copy Markdown

@athrvvvv @blueyed any changes still needed for merge?

Actually, one of the contributor must approve the changes of the checks, once it is done you PR will be merged 🫶

Also one suggestion, I don't think so the project is active anymore and if there, they must not feel that this commit is important... so just move on dude 🤝🏻

@Andrej730

Andrej730 commented Mar 8, 2023

Copy link
Copy Markdown
Author

Actually, one of the contributor must approve the changes of the checks, once it is done you PR will be merged 🫶

Also one suggestion, I don't think so the project is active anymore and if there, they must not feel that this commit is important... so just move on dude 🤝🏻

Ikr... but this package seems really nice and I want to be able to recommend it to people easily.
But currently it's broken but the fix is right there, just need to accept it 🥲

@athrvvvv

athrvvvv commented Mar 9, 2023

Copy link
Copy Markdown

Ikr... but this package seems really nice and I want to be able to recommend it to people easily.
But currently it's broken but the fix is right there, just need to accept it 🥲

Actually the project is open-source, if you really want yo fix the package just fork it and release your own version 👍
But do tell me when the package is released 😌

@Andrej730

Andrej730 commented Mar 9, 2023

Copy link
Copy Markdown
Author

Actually the project is open-source, if you really want yo fix the package just fork it and release your own version 👍
But do tell me when the package is released 😌

You mean to release it as some fancycompleter2? Like what happened to pyreadline... twice.

@athrvvvv

athrvvvv commented Mar 9, 2023

Copy link
Copy Markdown

Actually the project is open-source, if you really want yo fix the package just fork it and release your own version 👍
But do tell me when the package is released 😌

You mean to release it as some fancycompleter2? Like what happened to pyreadline... twice.

yes.

@blueyed

blueyed commented Mar 13, 2023

Copy link
Copy Markdown
Collaborator

Same as #41, no? Closing.

Will comment there.

@blueyed blueyed closed this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyreadline doesn't work on Python 3.10

3 participants