feat: add jira install-skill command#31
Conversation
pchuri
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround and thorough implementation @rajbdilip — the non-interactive overwrite handling, the npm tarball validation, and the SKILL.md content are all in great shape, and the test coverage is solid (248/248 passing locally).
A few notes inline. Two are correctness items worth addressing before merge (undocumented env vars in SKILL.md, and --dest not expanding ~); the rest are smaller consistency points.
Add a root-level install-skill command that copies a packaged Jira SKILL.md into the current project. Include package publishing support for skills/, documentation, and focused command tests.
02971e3 to
ffd95ba
Compare
|
Thanks again, @pchuri, for the careful review and for pointing out the things I missed. I’ve addressed the comments and amended the existing commit. I usually prefer keeping a PR to a single logical commit, but if you’d rather I use follow-up commits during review for easier change tracking, I’m happy to do that in future PRs. I also re-validated with:
|
pchuri
left a comment
There was a problem hiding this comment.
LGTM — all six review points addressed cleanly:
JIRA_CLI_CONFIG_PATH/JIRA_CLI_VERBOSErows removed from SKILL.mdexpandHomePathapplied to--dest, with a focused test that mocksos.homedir- analytics tracking added on both success and failure paths, with
overwrittenmetadata asyncdropped from the action signature andreturn process.exit(1)cleaned upSECURITY.mdadded to thefilesarray (verified innpm pack --dry-run)
Verified locally: 249/249 tests pass, lint clean, smoke-tested jira install-skill --dest '~/skills/jira' against the real binary — expands correctly to $HOME/skills/jira/SKILL.md.
The security CI job failure is unrelated to this PR — same 3 vulnerabilities (axios, fast-uri, follow-redirects) reproduce on main. Tracking separately in #32.
Approving.
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
jira install-skillcommand with non-interactive overwrite handling via--forceskills/jira/SKILL.mdand expand it into a Confluence-style command referenceTesting
jira config --helpjira install-skillCloses #30
Reference design discussion: #30 (comment)