Skip to content

feat: add jira install-skill command#31

Merged
pchuri merged 1 commit into
pchuri:mainfrom
rajbdilip:feat/jira-install-skill
May 10, 2026
Merged

feat: add jira install-skill command#31
pchuri merged 1 commit into
pchuri:mainfrom
rajbdilip:feat/jira-install-skill

Conversation

@rajbdilip
Copy link
Copy Markdown
Contributor

Summary

  • add a root-level jira install-skill command with non-interactive overwrite handling via --force
  • package and publish skills/jira/SKILL.md and expand it into a Confluence-style command reference
  • document the new command in the README and add focused command tests

Testing

  • npm test
  • npm run lint
  • npm pack
  • install the generated tarball into a temp project and run:
    • jira config --help
    • jira install-skill

Closes #30
Reference design discussion: #30 (comment)

Copy link
Copy Markdown
Owner

@pchuri pchuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround and thorough implementation @rajbdilip — the non-interactive overwrite handling, the npm tarball validation, and the SKILL.md content are all in great shape, and the test coverage is solid (248/248 passing locally).

A few notes inline. Two are correctness items worth addressing before merge (undocumented env vars in SKILL.md, and --dest not expanding ~); the rest are smaller consistency points.

Comment thread skills/jira/SKILL.md Outdated
Comment thread bin/commands/install-skill.js Outdated
Comment thread bin/commands/install-skill.js Outdated
Comment thread bin/commands/install-skill.js Outdated
Comment thread package.json
Add a root-level install-skill command that copies a packaged Jira SKILL.md into the current project. Include package publishing support for skills/, documentation, and focused command tests.
@rajbdilip rajbdilip force-pushed the feat/jira-install-skill branch from 02971e3 to ffd95ba Compare May 10, 2026 05:51
@rajbdilip
Copy link
Copy Markdown
Contributor Author

Thanks again, @pchuri, for the careful review and for pointing out the things I missed.

I’ve addressed the comments and amended the existing commit. I usually prefer keeping a PR to a single logical commit, but if you’d rather I use follow-up commits during review for easier change tracking, I’m happy to do that in future PRs.

I also re-validated with:

  • npm run lint -- --quiet
  • npm test
  • npm pack --dry-run --ignore-scripts
  • a tarball install smoke test, including jira install-skill --dest '~/skills/jira'

Copy link
Copy Markdown
Owner

@pchuri pchuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — all six review points addressed cleanly:

  • JIRA_CLI_CONFIG_PATH / JIRA_CLI_VERBOSE rows removed from SKILL.md
  • expandHomePath applied to --dest, with a focused test that mocks os.homedir
  • analytics tracking added on both success and failure paths, with overwritten metadata
  • async dropped from the action signature and return process.exit(1) cleaned up
  • SECURITY.md added to the files array (verified in npm pack --dry-run)

Verified locally: 249/249 tests pass, lint clean, smoke-tested jira install-skill --dest '~/skills/jira' against the real binary — expands correctly to $HOME/skills/jira/SKILL.md.

The security CI job failure is unrelated to this PR — same 3 vulnerabilities (axios, fast-uri, follow-redirects) reproduce on main. Tracking separately in #32.

Approving.

@pchuri pchuri merged commit a40cb0c into pchuri:main May 10, 2026
4 of 5 checks passed
@rajbdilip rajbdilip deleted the feat/jira-install-skill branch May 10, 2026 06:22
github-actions Bot pushed a commit that referenced this pull request May 10, 2026
# [2.7.0](v2.6.0...v2.7.0) (2026-05-10)

### Bug Fixes

* **deps:** bump axios, follow-redirects, fast-uri to patched versions ([#33](#33)) ([066176c](066176c)), closes [#32](#32) [#32](#32)

### Features

* add jira install-skill command ([#31](#31)) ([a40cb0c](a40cb0c))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Claude Code Skills Integration

2 participants