Skip to content

fix(convert): route html → markdown through htmlToMarkdown #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pchuri merged 2 commits into from
May 10, 2026
Merged

fix(convert): route html → markdown through htmlToMarkdown #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c044d6
fix(convert): route html → markdown through htmlToMarkdown
pchuri May 10, 2026
2808007
test(convert): strengthen html → markdown test with discriminating input
pchuri May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/confluence.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2200,7 +2200,7 @@ program
const { convert: htmlToText } = require('html-to-text');
output = htmlToText(input, { wordwrap: 130 });
} else if (options.inputFormat === 'html' && options.outputFormat === 'markdown') {
output = converter.storageToMarkdown(input);
output = converter.htmlToMarkdown(input);
} else if (options.inputFormat === 'markdown' && options.outputFormat === 'text') {
const html = converter.markdown.render(input);
const { convert: htmlToText } = require('html-to-text');
Expand Down
13 changes: 13 additions & 0 deletions tests/convert.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,19 @@ describe('convert command', () => {
expect(output).toContain('<strong>bold</strong>');
});

test('html to markdown preserves fenced code blocks with language', () => {
// Multi-line <pre><code class="language-*"> is the discriminating case
// between htmlToMarkdown and storageToMarkdown: the former emits a
// fenced block with the language tag, the latter collapses the body
// into inline `code` and drops the language. This test fails if the
// html → markdown path is ever routed back through storageToMarkdown.
const html = '<p><strong>bold</strong></p>\n<pre><code class="language-js">const x = 1;\nconst y = 2;</code></pre>';
const inputFile = writeInput('input.html', html);
const output = run(['convert', '--input-file', inputFile, '--input-format', 'html', '--output-format', 'markdown']);
expect(output).toContain('**bold**');
expect(output).toMatch(/```js\nconst x = 1;\nconst y = 2;\n```/);
});

test('storage to text', () => {
const inputFile = writeInput('input.xml', '<h1>Title</h1><p>Content</p>');
const output = run(['convert', '--input-file', inputFile, '--input-format', 'storage', '--output-format', 'text']);
Expand Down