Batch writes#76
Open
arminsabouri wants to merge 2 commits into
Open
Conversation
arminsabouri
force-pushed
the
mmap-index-files
branch
from
0ac471a to
93a9f4f
Compare
arminsabouri
force-pushed
the
batch-writes
branch
2 times, most recently
from
111b95e to
2836726
Compare
arminsabouri
commented
May 6, 2026
| return Err(io::Error::new(io::ErrorKind::InvalidData, len_error)); | ||
| } | ||
| let len = len_bytes / (N as u64); | ||
| file.seek(SeekFrom::End(0))?; |
Collaborator
Author
There was a problem hiding this comment.
This might break when we do incremental index building
bc1cindy
approved these changes
May 12, 2026
Contributor
bc1cindy
left a comment
bc1cindy
left a comment
There was a problem hiding this comment.
ACK
ran dense_parse_mainnet_702861 locally against the PR's merge base
base: ~46.8 ms median, this branch: ~20.9 ms median. ~2.24x speedup on a single mainnet block (criterion, 100 samples, macOS)
nice TxIdCollector split &ConfirmedTxPtrIndex + owned BlockBatch sidesteps the borrow conflict cleanly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffer index writes. Partially fixes #71 . There are some other copies I want to eliminate during serialization.