Spark eks job cancel + small janitor query modification #81
+75
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This PR enables cleanup in sparkeks plugin. Because the Cleanup() function does not include a Runtime object in the signature, some of the functions had to be modified slightly, the main one being where the kubeconfig file would be created.
The stale query modification prevents a race condition where the janitor can actually move a job from 'canceling' to 'canceled' before the go context actually cancels context. This can lead to the new "failed" status overwriting the 'canceling' status. The query was tested and still only takes ~2-3ms.
Types of changes
Checklist