fixes to hasAnimations codemod#845
Conversation
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Thanks for making these changes @gitdallas - left some comments below, otherwise LGTM.
| <Table /> | ||
| </> | ||
| ); | ||
| %inputExample% |
There was a problem hiding this comment.
Just a quick question on this syntax - is this expected? Or would this need to be updated to include examples of the components updated in this PR?
| %inputExample% | |
| %inputExample% |
There was a problem hiding this comment.
It is, I've got a script that compiles all of these separate readme's together for the "real" readme and inserts the associated tsx files into these spots
There was a problem hiding this comment.
Super cool - thank you for the context here @wise-king-sullyman
| <Table hasAnimations /> | ||
| </> | ||
| ); | ||
| %outputExample% |
| "Consider adding hasAnimations prop to enable component animations."; | ||
|
|
||
| // Helper function to check if isTree prop exists and isn't explicitly false | ||
| function hasValidIsTreeProp(node: JSXOpeningElement): boolean { |
There was a problem hiding this comment.
Not that it would be a blocker for me, but there are some helpers in /helpers/JSXAttributes.ts that would probably let you not have as much custom logic in this rule for evaluating the isTree prop if you weren't aware of them.
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
4 participants
fixes some notes from post-merge reviews on #843 as well as an issue that came up where
hasAnimationsis supposed to go on SearchInputExpandable instead of SearchInput.