Skip to content

chore(Drawer): unskip integration test #12425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmcfaul merged 2 commits into from
May 13, 2026
+65 −64
Merged

chore(Drawer): unskip integration test #12425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6417d2
chore(Drawer): unskip integration test
thatblindgeye May 13, 2026
a137225
Updated snapshots and drawer test
thatblindgeye May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions packages/react-charts/src/victory/components/ChartBar/__snapshots__/ChartBar.test.tsx.snap
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions ...s/react-charts/src/victory/components/ChartBullet/__snapshots__/ChartBullet.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ A 0 0 0 0 1, 312.5, 85
index="0"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--200, #e0e0e0); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--200, #e0e0e0); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
/>
</g>
<g
Expand All @@ -399,7 +399,7 @@ A 0 0 0 0 1, 225, 85
index="0"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--100, #f2f2f2); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--100, #f2f2f2); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
/>
</g>
<g
Expand Down
6 changes: 3 additions & 3 deletions ...rc/victory/components/ChartBullet/__snapshots__/ChartBulletQualitativeRange.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ A 0 0 0 0 1, 399.99999999976666, 104.8
index="0"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--300, #c7c7c7); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--300, #c7c7c7); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
/>
</g>
<g
Expand All @@ -102,7 +102,7 @@ A 0 0 0 0 1, 399.9999999995882, 104.8
index="0"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--200, #e0e0e0); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--200, #e0e0e0); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
/>
</g>
<g
Expand All @@ -121,7 +121,7 @@ A 0 0 0 0 1, 399.9999999993, 104.8
index="0"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--100, #f2f2f2); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--100, #f2f2f2); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
/>
</g>
</svg>
Expand Down
32 changes: 16 additions & 16 deletions ...ges/react-charts/src/victory/components/ChartStack/__snapshots__/ChartStack.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ A 0 0 0 0 1, 85, 125.86206896551724
index="0"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
<path
d="M 123.33333333333331, 125.86206896551724
Expand All @@ -99,7 +99,7 @@ A 0 0 0 0 1, 133.33333333333331, 125.86206896551724
index="1"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
<path
d="M 171.66666666666666, 77.58620689655172
Expand All @@ -114,7 +114,7 @@ A 0 0 0 0 1, 181.66666666666666, 77.58620689655172
index="2"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
<path
d="M 219.99999999999997, 101.72413793103448
Expand All @@ -129,7 +129,7 @@ A 0 0 0 0 1, 229.99999999999997, 101.72413793103448
index="3"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
</g>
<g
Expand All @@ -148,7 +148,7 @@ A 0 0 0 0 1, 85, 139.6551724137931
index="0"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
<path
d="M 123.33333333333331, 139.6551724137931
Expand All @@ -163,7 +163,7 @@ A 0 0 0 0 1, 133.33333333333331, 139.6551724137931
index="1"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
<path
d="M 171.66666666666666, 108.62068965517243
Expand All @@ -178,7 +178,7 @@ A 0 0 0 0 1, 181.66666666666666, 108.62068965517243
index="2"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
<path
d="M 219.99999999999997, 125.86206896551724
Expand All @@ -193,7 +193,7 @@ A 0 0 0 0 1, 229.99999999999997, 125.86206896551724
index="3"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
</g>
<g
Expand All @@ -212,7 +212,7 @@ A 0 0 0 0 1, 85, 146.55172413793105
index="0"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
<path
d="M 123.33333333333331, 143.10344827586206
Expand All @@ -227,7 +227,7 @@ A 0 0 0 0 1, 133.33333333333331, 143.10344827586206
index="1"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
<path
d="M 171.66666666666666, 132.75862068965517
Expand All @@ -242,7 +242,7 @@ A 0 0 0 0 1, 181.66666666666666, 132.75862068965517
index="2"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
<path
d="M 219.99999999999997, 139.6551724137931
Expand All @@ -257,7 +257,7 @@ A 0 0 0 0 1, 229.99999999999997, 139.6551724137931
index="3"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
</g>
<g
Expand All @@ -276,7 +276,7 @@ A 0 0 0 0 1, 85, 150
index="0"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
<path
d="M 123.33333333333331, 150
Expand All @@ -291,7 +291,7 @@ A 0 0 0 0 1, 133.33333333333331, 150
index="1"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
<path
d="M 171.66666666666666, 150
Expand All @@ -306,7 +306,7 @@ A 0 0 0 0 1, 181.66666666666666, 150
index="2"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
<path
d="M 219.99999999999997, 150
Expand All @@ -321,7 +321,7 @@ A 0 0 0 0 1, 229.99999999999997, 150
index="3"
role="presentation"
shape-rendering="auto"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
/>
</g>
</g>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"tslib": "^2.8.1"
},
"devDependencies": {
"@patternfly/patternfly": "6.5.0-prerelease.88",
"@patternfly/patternfly": "6.5.0-prerelease.91",
"case-anything": "^3.1.2",
"css": "^3.0.0",
"fs-extra": "^11.3.3"
Expand Down
2 changes: 1 addition & 1 deletion packages/react-docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"test:a11y": "patternfly-a11y --config patternfly-a11y.config"
},
"dependencies": {
"@patternfly/patternfly": "6.5.0-prerelease.88",
"@patternfly/patternfly": "6.5.0-prerelease.91",
"@patternfly/react-charts": "workspace:^",
"@patternfly/react-code-editor": "workspace:^",
"@patternfly/react-core": "workspace:^",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-icons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@fortawesome/free-brands-svg-icons": "^5.15.4",
"@fortawesome/free-regular-svg-icons": "^5.15.4",
"@fortawesome/free-solid-svg-icons": "^5.15.4",
"@patternfly/patternfly": "6.5.0-prerelease.88",
"@patternfly/patternfly": "6.5.0-prerelease.91",
"@rhds/icons": "^2.2.0",
"fs-extra": "^11.3.3",
"tslib": "^2.8.1"
Expand Down
Binary file removed packages/react-integration/cypress/downloads/downloads.html
View file
Open in desktop
Binary file not shown.
11 changes: 6 additions & 5 deletions packages/react-integration/cypress/integration/drawer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const visitDrawerDemoWithGlassTheme = () => {
const visitDrawerDemoWithGlassTheme = (viewportWidth: number = 1280) => {
cy.visit('http://localhost:3000/drawer-demo-nav-link');
cy.viewport(1280, 800);
cy.viewport(viewportWidth, 800);
cy.document().then((doc) => {
doc.documentElement.classList.add('pf-v6-theme-glass');
});
Expand Down Expand Up @@ -129,9 +129,10 @@ describe('Drawer Demo Test', () => {
});
});

// Blocked on Core: https://github.com/patternfly/patternfly/issues/8340
it.skip('glass theme: drawer panel has no glass CSS when isGlass is false', () => {
visitDrawerDemoWithGlassTheme();
// We only want to test at mobile viewport for this, as at desktop a drawer panel should correclty have
// a transprent (or rgba(0,0,0,0)) background, which incorrectly triggers a failure here.
it('glass theme: drawer panel has no glass CSS when isGlass is false', () => {
visitDrawerDemoWithGlassTheme(700);

cy.get('#drawer-glass-theme-no-isglass.pf-v6-c-drawer').should(($drawer) => {
expect($drawer).to.have.length(1);
Expand Down
2 changes: 1 addition & 1 deletion packages/react-styles/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"clean": "rimraf dist css"
},
"devDependencies": {
"@patternfly/patternfly": "6.5.0-prerelease.88",
"@patternfly/patternfly": "6.5.0-prerelease.91",
"change-case": "^5.4.4",
"fs-extra": "^11.3.3"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react-tokens/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
"devDependencies": {
"@adobe/css-tools": "^4.4.4",
"@patternfly/patternfly": "6.5.0-prerelease.88",
"@patternfly/patternfly": "6.5.0-prerelease.91",
"fs-extra": "^11.3.3"
}
}
18 changes: 9 additions & 9 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5070,10 +5070,10 @@ __metadata:
languageName: node
linkType: hard

"@patternfly/patternfly@npm:6.5.0-prerelease.88":
version: 6.5.0-prerelease.88
resolution: "@patternfly/patternfly@npm:6.5.0-prerelease.88"
checksum: 10c0/b4a4b65d048ec4ca6d9e445d24e2e4b309af0de4ed62fbfce7399d851a79947450fd923a9cf0e5702750fa535d1631b108fc45fe54090b6b1452b653e21402c6
"@patternfly/patternfly@npm:6.5.0-prerelease.91":
version: 6.5.0-prerelease.91
resolution: "@patternfly/patternfly@npm:6.5.0-prerelease.91"
checksum: 10c0/37a2472bde01285ccd4bc344b8169fb05d17784214b9b572fb35c27452b1e6a81fa34ac8bf10c789d5d9f22d1f65ffe87ba15870906afdc7fe1e47dad94ec086
languageName: node
linkType: hard

Expand Down Expand Up @@ -5171,7 +5171,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@patternfly/react-core@workspace:packages/react-core"
dependencies:
"@patternfly/patternfly": "npm:6.5.0-prerelease.88"
"@patternfly/patternfly": "npm:6.5.0-prerelease.91"
"@patternfly/react-icons": "workspace:^"
"@patternfly/react-styles": "workspace:^"
"@patternfly/react-tokens": "workspace:^"
Expand All @@ -5192,7 +5192,7 @@ __metadata:
resolution: "@patternfly/react-docs@workspace:packages/react-docs"
dependencies:
"@patternfly/documentation-framework": "npm:^6.36.8"
"@patternfly/patternfly": "npm:6.5.0-prerelease.88"
"@patternfly/patternfly": "npm:6.5.0-prerelease.91"
"@patternfly/patternfly-a11y": "npm:5.1.0"
"@patternfly/react-charts": "workspace:^"
"@patternfly/react-code-editor": "workspace:^"
Expand Down Expand Up @@ -5232,7 +5232,7 @@ __metadata:
"@fortawesome/free-brands-svg-icons": "npm:^5.15.4"
"@fortawesome/free-regular-svg-icons": "npm:^5.15.4"
"@fortawesome/free-solid-svg-icons": "npm:^5.15.4"
"@patternfly/patternfly": "npm:6.5.0-prerelease.88"
"@patternfly/patternfly": "npm:6.5.0-prerelease.91"
"@rhds/icons": "npm:^2.2.0"
fs-extra: "npm:^11.3.3"
tslib: "npm:^2.8.1"
Expand Down Expand Up @@ -5319,7 +5319,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@patternfly/react-styles@workspace:packages/react-styles"
dependencies:
"@patternfly/patternfly": "npm:6.5.0-prerelease.88"
"@patternfly/patternfly": "npm:6.5.0-prerelease.91"
change-case: "npm:^5.4.4"
fs-extra: "npm:^11.3.3"
languageName: unknown
Expand Down Expand Up @@ -5361,7 +5361,7 @@ __metadata:
resolution: "@patternfly/react-tokens@workspace:packages/react-tokens"
dependencies:
"@adobe/css-tools": "npm:^4.4.4"
"@patternfly/patternfly": "npm:6.5.0-prerelease.88"
"@patternfly/patternfly": "npm:6.5.0-prerelease.91"
fs-extra: "npm:^11.3.3"
languageName: unknown
linkType: soft
Expand Down
Loading