Skip to content

fix(tui): prevent config reset from being undone - #91

Merged
patricksmill merged 1 commit into
mainfrom
cursor/critical-bug-management-3056
Sep 28, 2026
Merged

patricksmill merged 1 commit into
mainfrom
cursor/critical-bug-management-3056

Conversation

@cursor

@cursor cursor Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Prevent the TUI from silently recreating config.json and keyring-backed settings after Settings reset. A reset now marks the running app as needing restart, blocks subsequent Settings/layout persistence in that session, and reports reset failures.

Crate(s)

  • romm-api
  • romm-cli
  • romm-tui
  • docs / CI only

Checklist

  • cargo fmt --check passes
  • Both cargo clippy runs pass (--all-features and --no-default-features, -D warnings)
    • Ran scoped check: cargo +stable clippy -p romm-tui --all-targets -- -D warnings
  • cargo test --workspace passes (or scoped tests with reason)
    • Scoped tests: cargo +stable test -p romm-tui
  • PR title uses Conventional Commits with the right scope for the changelog
  • No secrets, tokens, or personal config in the diff
  • User-facing changes documented in the relevant docs/*.md if needed
    • Not needed: preserves existing Settings reset message/behavior, but prevents stale in-memory persistence until restart.
Open in Web View Automation 

Co-authored-by: Patrick Mill <patricksmill@users.noreply.github.com>
@patricksmill
patricksmill marked this pull request as ready for review September 28, 2026 20:27
@patricksmill
patricksmill force-pushed the cursor/critical-bug-management-3056 branch from 10dc3da to 6965d60 Compare September 28, 2026 20:27
@patricksmill
patricksmill merged commit ef8be33 into main Sep 28, 2026
1 of 13 checks passed
@patricksmill
patricksmill deleted the cursor/critical-bug-management-3056 branch September 28, 2026 20:27
@github-actions github-actions Bot mentioned this pull request Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants