Repository navigation
fix(api): guard OpenAPI auth fallback origin - #71
Merged
Merged
Conversation
Co-authored-by: Patrick Mill <patricksmill@users.noreply.github.com>
Co-authored-by: Patrick Mill <patricksmill@users.noreply.github.com>
patricksmill
marked this pull request as ready for review
September 28, 2026 20:30
patricksmill
force-pushed
the
cursor/critical-bug-management-eed4
branch
from
September 28, 2026 20:30
ae91a17 to
64cefe3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAPI discovery now only attaches configured auth headers to candidate URLs that match the resolved OpenAPI origin (scheme, host, and port). This prevents HTTP-configured clients from sending credentials to HTTPS fallback services while preserving authenticated same-origin discovery.
Crate(s)
Checklist
cargo +stable fmt --all -- --checkpassescargo +stable clippy -p romm-api --all-features -- -D warningsandcargo +stable clippy -p romm-api --no-default-features -- -D warningscargo +stable test -p romm-api(API-only security fix)docs/*.mdif needed (not needed for this internal security guard)