Repository navigation
fix(api): redact OpenAPI fallback errors - #70
Merged
Merged
Conversation
Co-authored-by: Patrick Mill <patricksmill@users.noreply.github.com>
Co-authored-by: Patrick Mill <patricksmill@users.noreply.github.com>
Co-authored-by: Patrick Mill <patricksmill@users.noreply.github.com>
Co-authored-by: Patrick Mill <patricksmill@users.noreply.github.com>
Co-authored-by: Patrick Mill <patricksmill@users.noreply.github.com>
patricksmill
marked this pull request as ready for review
September 28, 2026 20:29
patricksmill
force-pushed
the
cursor/critical-bug-management-6817
branch
from
September 28, 2026 20:29
5dd97d4 to
0e96e10
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix OpenAPI fallback error aggregation so failed authenticated spec downloads do not embed raw HTTP response bodies or nested request URLs in aggregate errors. This prevents later logging/user-facing paths from exposing echoed Authorization headers or URL credentials/query tokens.
Crate(s)
Checklist
cargo fmt --checkpasses (cargo +stable fmt --all -- --check)cargo clippyruns pass for touched crate (cargo +stable clippy -p romm-api --all-features -- -D warnings;cargo +stable clippy -p romm-api --no-default-features -- -D warnings)cargo +stable test -p romm-api)docs/*.mdif needed (not needed; logging/error sanitization only)