Repository navigation
fix(tui): guard metadata background races - #62
Merged
Merged
Conversation
Co-authored-by: Patrick Mill <patricksmill@users.noreply.github.com>
patricksmill
marked this pull request as ready for review
September 28, 2026 20:29
patricksmill
force-pushed
the
cursor/critical-bug-management-2bf5
branch
from
September 28, 2026 20:29
f9241d1 to
1de572f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent stale metadata-search completions and overlapping metadata match/unmatch writes from corrupting the active TUI metadata flow for a ROM. Metadata picker sessions now use a generation guard, and metadata writes block duplicate writes for the same ROM until completion.
Crate(s)
Checklist
cargo fmt --checkpassescargo clippyruns pass (--all-featuresand--no-default-features,-D warnings)cargo test --workspacepasses (or scoped tests with reason)docs/*.mdif neededScoped test reason: changes are limited to
romm-tui; rancargo +stable test -p romm-tui. Usedcargo +stablebecause the default Cargo 1.83 cannot parse the currentrpasswordedition-2024 manifest.