Repository navigation
fix(tui): show typing indicators across all text forms - #108
Open
patricksmill wants to merge 2 commits into
Open
patricksmill wants to merge 2 commits into
patricksmill wants to merge 2 commits into
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the existing inline caret convention across metadata search, game search, library filters, settings URL editing, focused path bars (including upload and console-directory pickers), and all setup/auth text fields. Long values scroll to keep the insertion marker visible. Password/API-key fields remain masked. Remove the separate terminal-cursor paths and their duplicated layout calculations.
Evidence
After: actual terminal rendering showed
Search: Shrek's Carnival Craze Party Games▏.PASS: all active typing surfaces expose exactly one visible caret; inactive fields expose none. Smoke source removed.cargo test --workspace: 439 passed across 28 suites, including updated wizard masking/caret regression coverage.cargo fmt --check: passed.cargo clippy --all-targets ... -- -D warnings: passed.bash tools/release-check.sh:release-check: all checks passed(API package dry-run and frontend release builds; no upload).Merge Danger
Door: two-way
Rendering-only change; no configuration migration, new dependency, or input-editing behavior change. Rust consumers of the removed screen-specific cursor-position helpers must stop calling them; render methods now own the indicator.
Blast Radius: typing
Shared single-line clipping controls visible insertion points across TUI forms. Terminal-native cursor positioning is replaced by the persistent inline marker. No live-server behavior was exercised.