Repository navigation
refactor(tui): centralize library selection and preserve saved identity - #107
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Concentrate platform/manual/smart/virtual selection interpretation and remove separate request methods plus App forwarding. Includes prerequisite saved-selection persistence/restoration changes that were already uncommitted in the checkout; these are required for the behavior covered by the spec. Agent-skill setup files are excluded.
Closes #105
Closes #106
Evidence
17 passed; 0 failed, including overlapping collection IDs and missing versus empty virtual IDs.After: the same suite:
17 passed; 0 failedafter consolidation.cargo test --workspace: 439 passed across 28 suites.cargo fmt --checkand bothcargo clippy --all-targets --all-features -- -D warningsandcargo clippy --all-targets --no-default-features -- -D warningscompleted successfully.cargo run -p romm-tui --example selection_smokeprintedPASS: filtered smart selection, request identity, saved restoration, neighbor prefetch, metadata reorder and count-change reload. Smoke source removed afterward.Merge Danger
Door: two-way
No cache-format migration. Prerequisite persistence adds an optional, defaulted
tui_layout.library_selectionconfiguration field. Existing configuration files remain readable. The library-browse Rust interface replacesget_roms_request_platform/get_roms_request_collectionwithget_roms_request; in-repo callers are migrated, but external Rust consumers using those methods must migrate too.Blast Radius: library
Affects library selection, request targeting, prefetch, and saved-selection restoration. Generation guards, cancellation, debounce, and cache-paint policy are unchanged.