Optimised code

.github/workflows/actions.yml

@@ -2,7 +2,7 @@ name: run main.py
 
 on:
   schedule:
-    - cron: '0 0 * * 1' # At 00:00 on Monday
+    - cron: '0 */2 * * *'  # Every 2 hours
 
 jobs:
   build:

.github/workflows/pylint.yml

@@ -0,0 +1,24 @@
+name: Pylint
+
+on: [push]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: ["3.8", "3.9", "3.10"]
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v3
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install pylint
+        pip install -r requirements.txt
+    - name: Analysing the code with pylint
+      run: |
+        pylint $(git ls-files '*.py')

main.py

@@ -1,34 +1,85 @@
+"""
+Retrieve weather data for a given city and log it.
+"""
+
+import csv
 import logging
-import logging.handlers
+from datetime import datetime
+from typing import Optional
 import os
 
+import pytz
 import requests
 
 logger = logging.getLogger(__name__)
 logger.setLevel(logging.DEBUG)
-logger_file_handler = logging.handlers.RotatingFileHandler(
-    "status.log",
-    maxBytes=1024 * 1024,
-    backupCount=1,
-    encoding="utf8",
-)
-formatter = logging.Formatter("%(asctime)s - %(name)s - %(levelname)s - %(message)s")
-logger_file_handler.setFormatter(formatter)
-logger.addHandler(logger_file_handler)
-
-try:
-    SOME_SECRET = os.environ["SOME_SECRET"]
-except KeyError:
-    SOME_SECRET = "Token not available!"
-    #logger.info("Token not available!")
-    #raise
+logger.addHandler(logging.StreamHandler())
 
 
-if __name__ == "__main__":
-    logger.info(f"Token value: {SOME_SECRET}")
+def get_weather_data(city: str) -> Optional[dict]:
+    """
+    Get weather data for the given city from the Talk Python Weather API.
+
+    :param city: The city for which to get the weather data.
+    :return: A dictionary containing the weather data or None if the request failed.
+    """
+    api_url = "https://weather.talkpython.fm/api/weather/"
+    params = {"city": city, "country": "IN"}
+    try:
+        response = requests.get(api_url, params=params, timeout=10)
+        return response.json() if response.status_code == 200 else None
+    except (requests.Timeout, requests.RequestException):
+        return None
+
+
+def log_weather_data(city: str, data: dict) -> None:
+    """
+    Log the weather data for a given city.
+
+    :param city: The city for which the weather data is logged.
+    :param data: The weather data to be logged.
+    """
+    logger.info("City: %s", city)
+    logger.info("Temperature: %s", data.get("forecast", {}).get("temp"))
+    logger.info("Feels Like: %s", data.get("forecast", {}).get("feels_like"))
+    logger.info("Humidity: %s", data.get("forecast", {}).get("humidity"))
+
+    utc_now = datetime.utcnow()
+    ist_now = utc_now.astimezone(pytz.timezone("Asia/Kolkata"))
+
+    logger.info("Current IST time: %s", ist_now.strftime("%Y-%m-%d %H:%M:%S"))
 
-    r = requests.get('https://weather.talkpython.fm/api/weather/?city=Berlin&country=DE')
-    if r.status_code == 200:
-        data = r.json()
-        temperature = data["forecast"]["temp"]
-        logger.info(f'Weather in Berlin: {temperature}')
+    with open("weather_data.csv", mode="a", newline="", encoding="utf-8") as file:
+        writer = csv.writer(file)
+        if file.tell() == 0:
+            writer.writerow(["Timestamp", "Temperature", "Feels Like", "Humidity"])
+        writer.writerow(
+            [
+                ist_now.strftime("%Y-%m-%d %H:%M:%S"),
+                data.get("forecast", {}).get("temp"),
+                data.get("forecast", {}).get("feels_like"),
+                data.get("forecast", {}).get("humidity"),
+            ]
+        )
+
+
+def main() -> None:
+    """
+    The main function for this module.
+    """
+    token = os.environ.get("SOME_SECRET")
+    if token is None:
+        logger.error("Token value is not available.")
+        return
+
+    city = "Pune"
+    data = get_weather_data(city)
+    if data is None:
+        logger.error("Failed to get weather data for %s.", city)
+        return
+
+    log_weather_data(city, data)
+
+
+if __name__ == "__main__":
+    main()

requirements.txt

@@ -1 +1,2 @@
-requests==2.28.1
+requests==2.31.0
+pytz