fix: require Node 22 for vsce 4 packaging - #282
Merged
Merged
Conversation
@vscode/vsce 4 and ovsx 1.2 need Node >= 22. engines.node still said >= 20, so a Node 20 checkout could install and pass unit tests, then fail at vsce package. .nvmrc was already 22. Unit test compares engines.node to the installed vsce and ovsx engines. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
CONTRIBUTING still said Node.js 20+ after engines.node moved to >=22. AGENTS.md lists the package engines unit test. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Patch update inside the existing ^26.6.2 range. @types/vscode stays on 1.90 to match engines.vscode. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
SebTardif
marked this pull request as ready for review
September 28, 2026 16:03
SebTardif
enabled auto-merge (squash)
September 28, 2026 16:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vscode/vsce4 andovsx1.2 need Node >= 22.engines.nodestill said>=20, so a Node 20 checkout could install and pass unit tests, then fail atvsce package..nvmrcwas already 22.A unit test compares
engines.nodeto the installed vsce and ovsx engines. CONTRIBUTING now says Node.js 22+. The@types/nodelock moves to 26.6.3.@types/vscodestays on 1.90 so it does not exceedengines.vscode.Why
vsce 4 landed in #277. CI stayed green because setup-node reads
.nvmrc, notengines.node. The published engines field and the contributor doc still described a Node 20 floor the packaging CLI cannot run.Verification
npm run check(449 unit tests, line coverage,vsce package)Checklist
git commit -snpm run checkand it passes