Repository navigation
fix: refresh native MCP when settings or trust change - #241
Merged
Merged
Conversation
Settings and trust listeners now clear the shared status probe, then refresh the status bar and the native MCP binary path. Inflight-clear tests now keep the replacement probe open so the identity guard is actually exercised. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
marked this pull request as ready for review
August 28, 2026 01:56
SebTardif
enabled auto-merge (squash)
August 28, 2026 01:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
patchloom.pathor workspace trust changes, native MCP now picks up the new CLI path instead of keeping the activate-time binary. The in-flight--versionclear test now holds the replacement probe open so the identity guard is actually checked.Why
PR #240 shared one status probe and cleared it on settings change, but only refreshed the status bar. Native MCP still served the old stdio command until reload.
The change
refreshAfterPatchloomInputChangeclears inflight, then refreshes status bar and MCPVerification
npm run check(373 passed, 6 skipped)Checklist
git commit -snpm run checkand it passes