Skip to content

fix: refresh native MCP when settings or trust change - #241

Merged
SebTardif merged 1 commit into
mainfrom
fix/improve-mpi-20260827-s1846
Aug 28, 2026
Merged

SebTardif merged 1 commit into
mainfrom
fix/improve-mpi-20260827-s1846

Conversation

@SebTardif

Copy link
Copy Markdown
Contributor

Summary

When patchloom.path or workspace trust changes, native MCP now picks up the new CLI path instead of keeping the activate-time binary. The in-flight --version clear test now holds the replacement probe open so the identity guard is actually checked.

Why

PR #240 shared one status probe and cleared it on settings change, but only refreshed the status bar. Native MCP still served the old stdio command until reload.

The change

  • refreshAfterPatchloomInputChange clears inflight, then refreshes status bar and MCP
  • Config, folder, and trust listeners use that helper
  • Unit test locks clear-then-status-then-MCP order
  • Inflight-clear test joins a third caller onto the second probe while the first is still finishing

Verification

  • npm run check (373 passed, 6 skipped)

Checklist

  • All commits in this pull request are signed off with git commit -s
  • I ran npm run check and it passes
  • I updated docs if user-facing behavior changed
  • I am contributing this work under the repository license (MIT)

Settings and trust listeners now clear the shared status probe, then
refresh the status bar and the native MCP binary path. Inflight-clear
tests now keep the replacement probe open so the identity guard is
actually exercised.

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
@SebTardif
SebTardif marked this pull request as ready for review August 28, 2026 01:56
@SebTardif
SebTardif enabled auto-merge (squash) August 28, 2026 01:56
@SebTardif
SebTardif merged commit 5d8e65d into main Aug 28, 2026
22 checks passed
@SebTardif
SebTardif deleted the fix/improve-mpi-20260827-s1846 branch August 28, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant