Repository navigation
fix: write CLI failures to Output and register MCP after install - #238
Merged
Merged
Conversation
Hard errors that already opened the channel now write stdout/stderr when trace is off. Settings copy no longer implies every CLI stream is trace-gated. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Followed Location headers must stay on GitHub release hosts. Relative redirects are resolved against the current URL. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Always register the MCP server definition provider when the VS Code API exists, resolve the binary path on demand, and refresh after managed install/update/reinstall so native MCP works without a window reload. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Warn and return when a batch plan has no operations, surface suggested_op as a try-next-step toast, and align CONTRIBUTING.md test script docs with package.json (unit-only npm test; UI tests outside test:all). Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
marked this pull request as ready for review
August 28, 2026 01:19
SebTardif
enabled auto-merge (squash)
August 28, 2026 01:19
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLI results that already opened the Patchloom output channel now write stdout/stderr when
trace.serveris off (patch-merge hard errors and batch apply). Managed-install redirects stay on GitHub release hosts. Native MCP registers even if the CLI is installed later in the session. Empty batch plans no longer report success.Why
After PR #237, success and conflict paths wrote to Output, but some failures still called
show()on an empty channel. First-run Install never attached the native MCP provider until reload. Local docs callednpm run checkthe full merge gate.The change
presentCliResultInOutputcheck/testfrom extension and UI CIformatCliOutputsaystry <op>instead ofsuggested_op: <op>Verification
npm run check(368 passed, 6 skipped)Checklist
git commit -snpm run checkand it passes