Repository navigation
fix: harden CLI env and align MPI follow-ups with CLI 0.31 - #236
Merged
Merged
Conversation
- Numeric selector via buildDocGetQuickAction - search -L all-hits no_matches + formatCliOutput stderr - create parent-path via builder, YAML alias doc set, agent-rules core+mode Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
- Create Quick Action now uses resolveWorkspaceRelativePath - generateAgentRules throws formatCliOutput so error_kind and suggested_op appear - readTextFileIfExists treats only FileNotFound as missing AGENTS.md Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Pass patchloom.env to CLI spawn sites and honor patchloom.trace.server for command/result logging. Surface next-step hints on path, missing file, markdown, and MCP timeout errors. Catch AGENTS.md permission errors and preview failures instead of failing the command uncaught. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Pin @types/vscode to ~1.90.0 so the lock cannot float past engines.vscode (^1.90.0). vsce rejects a declared @types/vscode range newer than engines. Bump @types/node to 26.4.0. Audit the full graph in CI (including devDependencies) because the production graph is empty. Refresh AGENTS.md unit test counts to match grep. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Only PATCHLOOM_* keys overlay the CLI env. Workspace env is ignored in untrusted folders. Patch merge keeps --contain when the patch lives in the workspace. CI compiles out-uitest before ExTester. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Filenames such as ..changes.patch stay inside the workspace sandbox. isPathInsideWorkspace compares resolved prefixes (case-fold on macOS/Windows). npm test now compiles out-uitest so it matches CI. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
marked this pull request as ready for review
August 27, 2026 21:12
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
SebTardif
enabled auto-merge (squash)
August 27, 2026 21:12
UI tests now compile in CI. The suite opens a workspace without AGENTS.md, so content-based activation never ran and before() timed out. Invoke Show Status first to load the extension. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
The command palette InputBox was treated as the Quick Action picker when getQuickPicks() returned empty labels. Keep polling until a Patchloom notification or a Replace/Tidy pick appears. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MPI cycle after the CLI 0.31 alignment. One session branch with tests, error-path fixes, and a trust fix for
patchloom.env.Why
New 0.31 surfaces were recommended without live Quick Action coverage. Wiring
patchloom.envthen let a workspace overlayPATH/LD_PRELOADonto the managed binary. CI UI tests compiled the wrong tree.The change
search -Lall-hits, YAML aliasdoc set, parent-path create via builders, andagent-rules --surface core --modeformatCliOutput; Create usesresolveWorkspaceRelativePath; AGENTS.md read treats only FileNotFound as missingpatchloom.envis honored, then restricted toPATCHLOOM_*and ignored from untrusted workspace settings--containwhen the patch is inside the workspacenpm testcompileout-uitestbefore ExTester@types/vscodeto~1.90.0; npm audit in CI includes devDependenciesVerification
npm run check(run locally before push)Checklist
git commit -snpm run checkand it passes