Skip to content

fix: Fix for the "too many requests" issue #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wxqqh wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Fix for the "too many requests" issue #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5365e77
fix: Fix for the "too many requests" issue
Oct 17, 2022
1af08dc
fix: delete agent param from querystring
Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,12 @@ export default function request({method, host, path, qs, agent}) {
});

res.on('end', () => {
if (res.statusCode === 429 && res.headers['set-cookie']) {
if (res.statusCode === 429) {
// Fix for the "too many requests" issue
// Look for the set-cookie header and re-request
cookieVal = res.headers['set-cookie'][0].split(';')[0];
options.headers = {'cookie': cookieVal};
cookieVal = res.headers['set-cookie'] ?
res.headers['set-cookie'][0].split(';')[0] : '';
options.headers = cookieVal ? {'cookie': cookieVal} : {};
rereq(options, function(err, response) {
if (err) return reject(err);
resolve(response);
Expand Down
4 changes: 4 additions & 0 deletions src/utilities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,10 @@ export function parseResults(results) {
* @return {Array} Returns an array of comparisonItems
*/
export function formatComparisonItems(obj) {
// fix the querystring has the agent param from obj
obj = Object.assign({}, obj);
delete obj.agent;

const isMultiRegion = obj.geo && Array.isArray(obj.geo);
let isMultiKeyword = Array.isArray(obj.keyword);

Expand Down