Repository navigation
refactor: Remove unused dependency codecov - #637
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #637 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 11 11
Lines 1841 1841
=======================================
Hits 1826 1826
Misses 15 15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🎉 This change has been released in version 8.5.9 |
Pull Request
Issue
Resolves Dependabot alerts #238, #233, #211, #204 and #81.
These alerts are for
js-yamlin the development dependency tree:>= 3.0.0, < 3.15.2>= 3.0.0, < 3.15.1>= 3.0.0, < 3.15.0< 3.15.0< 3.14.2The only vulnerable copy on
masterisnode_modules/js-yaml3.14.1, which onlycodecov3.8.3 uses.codecov3.8.3 pinsjs-yamlto exactly 3.14.1, so the copy cannot be updated in place.codecov3.8.3 (July 2021) is the last release of the package. It is deprecated on npm in favor of the new Codecov uploader, and its repositorycodecov/codecov-nodeis archived, so no fixed version will be released.The package is also unused. No npm script, config file or workflow runs it. CI uploads coverage with
codecov/codecov-action@v4in.github/workflows/ci.yml, which does not use this npm package. Instead of pinning around it, this PR removes the dependency.The removal also drops the development copy of
@tootallnate/once1.1.2. Dependabot alert #179 (@tootallnate/once< 2.0.1) stays open, because the copies of@tootallnate/once2.0.0 underfirebase-admin>@google-cloud/storageare production dependencies and out of scope for this development-only change.Approach
Changes
package.json: removes thecodecov(3.8.3) devDependency.package-lock.json: regenerated frommasterwithnpm uninstall codecov --ignore-scripts --package-lock-only. It removescodecovand the 17 packages that only it used:js-yaml3.14.1, withargparse1.0.10,sprintf-js1.0.3 andesprima4.0.1teeny-request7.1.1 with its nesteduuid8.3.2, andhttp-proxy-agent4.0.1 with@tootallnate/once1.1.2ignore-walk3.0.4, withminimatch3.1.5,brace-expansion1.1.21,balanced-match1.0.2 andconcat-map0.0.1urlgrey1.0.0, withfast-url-parser1.1.3 and its nestedpunycode1.4.1argv0.0.2The entries for
agent-base6.0.2,https-proxy-agent5.0.0,node-fetch2.7.0,stream-events1.0.5,stubs3.0.0,tr460.0.3,webidl-conversions3.0.1 andwhatwg-url5.0.0 stay at their versions. They change fromdevOptionaltooptional, because the remaining packages that need them are in the optional dependency subtree offirebase-admin. No package is added and no version changes.lockfileVersionis unchanged (2).After this change, the lock file resolves
js-yamlonly to 4.3.2, which is not affected by these advisories.Breaking Changes
None.
codecovis a development-only tool that is not shipped in the published package and is not invoked by any script or CI job.Code Changes Required
None. No source, config or workflow files reference the
codecovnpm package. Coverage upload in CI and the coverage badge in the README are unchanged, because they use the Codecov GitHub Action and service, not this package.Tasks
No tasks apply: this removes an unused development dependency, with no tests or documentation to add.
Summary by CodeRabbit