Skip to content

fix(server): page dotNS pendingClaims through its (address,uint256,uint256) view - #574

Merged
pgherveou merged 3 commits into
mainfrom
fix/dotns-pending-claims-paging
Sep 2, 2026
Merged

fix(server): page dotNS pendingClaims through its (address,uint256,uint256) view#574
pgherveou merged 3 commits into
mainfrom
fix/dotns-pending-claims-paging

Conversation

@tallesborges

Copy link
Copy Markdown
Contributor

Fixes #573.

truapi-server now calls DotnsPopController.pendingClaims(address,uint256,uint256) instead of the removed pendingClaims(address). The controller on Paseo Next v2 and PreviewNet was upgraded in place to the paged signature (paritytech/dotns@31dc754), so the old call reverted and resolve_labels dropped every gateway-minted username that had not yet settled through claimLabelStore.

  • Pages through the view (16 per page, stops on a short page, warns if the page cap is reached). The contract caps limit at 200.
  • decode_pending_claims_array is unchanged; the return type did not move.
  • Selector expectation updated ca78533d76025b85, with exact calldata coverage.
  • runtime/identity.rs scripted controller asserts offset = 0 and 1 <= limit <= 200.

Not changed here: the revert-to-empty fallback in pending_claim_labels, which is what hid this regression. Tracked as the open question in #573.

Verified with cargo test -p truapi-server --lib -- dotns_gateway runtime::identity (21 passed) and cargo clippy -p truapi-server --all-targets -- -D warnings.

After merge, brevity-dozer needs its TRUAPI_REV pin bumped to pick this up.

@pgherveou

Copy link
Copy Markdown
Collaborator

ah man I should have found that earlier starting the exact same PR

@pgherveou
pgherveou added this pull request to the merge queue Sep 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 2, 2026
@tallesborges
tallesborges added this pull request to the merge queue Sep 2, 2026
@pgherveou
pgherveou removed this pull request from the merge queue due to a manual request Sep 2, 2026
@pgherveou

Copy link
Copy Markdown
Collaborator

will fix the flacky CI test and merge @tallesborges

@pgherveou
pgherveou enabled auto-merge September 2, 2026 11:51
@pgherveou
pgherveou added this pull request to the merge queue Sep 2, 2026
pgherveou added a commit that referenced this pull request Sep 2, 2026
Merged via the queue into main with commit d7a3f17 Sep 2, 2026
18 checks passed
@pgherveou
pgherveou deleted the fix/dotns-pending-claims-paging branch September 2, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

truapi-server calls old pendingClaims signature; pending usernames missing from resolution

2 participants