fix(server): page dotNS pendingClaims through its (address,uint256,uint256) view - #574
Merged
Conversation
Collaborator
|
ah man I should have found that earlier starting the exact same PR |
pgherveou
approved these changes
Sep 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 2, 2026
Collaborator
|
will fix the flacky CI test and merge @tallesborges |
pgherveou
enabled auto-merge
September 2, 2026 11:51
pgherveou
added a commit
that referenced
this pull request
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #573.
truapi-servernow callsDotnsPopController.pendingClaims(address,uint256,uint256)instead of the removedpendingClaims(address). The controller on Paseo Next v2 and PreviewNet was upgraded in place to the paged signature (paritytech/dotns@31dc754), so the old call reverted andresolve_labelsdropped every gateway-minted username that had not yet settled throughclaimLabelStore.limitat 200.decode_pending_claims_arrayis unchanged; the return type did not move.ca78533d→76025b85, with exact calldata coverage.runtime/identity.rsscripted controller assertsoffset = 0and1 <= limit <= 200.Not changed here: the revert-to-empty fallback in
pending_claim_labels, which is what hid this regression. Tracked as the open question in #573.Verified with
cargo test -p truapi-server --lib -- dotns_gateway runtime::identity(21 passed) andcargo clippy -p truapi-server --all-targets -- -D warnings.After merge,
brevity-dozerneeds itsTRUAPI_REVpin bumped to pick this up.