Open
Conversation
Merge from original repo
Update branch with latest modifications
|
Changes Unknown when pulling 526a98a on osechet:feature/fullscreen_dialog into ** on papyros:develop**. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I implemented the full-screen dialog (http://www.google.fr/design/spec/components/dialogs.html#dialogs-full-screen-dialogs) following the comments I made in the issue #287. I modified the demo to include the full-screen dialog in the " Compund Components" section.
I just had problems with the density management. My environment is not setup to build for Android so I could only test the dialog on a PC. But the pixel density returned by Qt for my monitor is surprising. So i'm using Units.multiplier until I get a better idea about that density issue.
I had to create a new OverlayLayer in ApplicationWindow in order to be able to open normal dialogs from the full-screen dialog..