Repository navigation
Tests: Install ConnectorX with the test extra - #429
Conversation
The cdc test for an empty source read through `--sql-backend connectorx` skips unless ConnectorX is importable, and no extra installed it, so it skipped on every CI lane. ConnectorX publishes no sdist and no Python 3.15 wheel, so the pin is marked `python_version<'3.15'`; without the marker the `test` extra does not resolve on 3.15.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
=======================================
Coverage 60.24% 60.24%
=======================================
Files 201 201
Lines 10344 10344
=======================================
Hits 6232 6232
Misses 4112 4112 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
test_cdc_on_an_empty_source_clears_it_with_connectorx, added with thecdcstrategy in #422, callspytest.importorskip("connectorx"). No extra installs ConnectorX, so it has been skipped on every CI lane since it landed: both the.[full,develop,test]integration lane and the.[develop,test]unit lane resolve without it. The pin it was written to hold has never actually run in CI.connectorx<0.5; python_version<'3.15'joins thetestextra.testextra fails to resolve on Python 3.15 (uv pip compile --python-version 3.15 --extra test: "all versions of connectorx have no wheels with a matching Python ABI tag"), which would get in the way of Verify support for Python 3.15 #386. Once ConnectorX ships a 3.15 wheel, the marker can go.testand not in a user-facing extra.--sql-backend connectorxalready exists, and the docs say to installconnectorxalongside it, so this PR only makes the existing test run. Whether ConnectorX should get its own extra, or end up infull, goes with ConnectorX #118 and is your call.Test plan
main(948a3a01), the Tests run reports the test as SKIPPED, anduv pip compilefor both CI extra sets resolves noconnectorx.+ connectorx==0.4.6installed, andtest_cdc_on_an_empty_source_clears_it_with_connectorxPASSED on all four..[develop,test]: the unit-lane command gives 1257 passed, 59 skipped. Withconnectorxuninstalled, the test reportsSKIPPED ... could not import 'connectorx'again.uv pip compile --extra testresolvesconnectorx==0.4.6for 3.14 and leaves it out for 3.15.validate-pyprojectandruffare clean.pyproject-fmt --checkaccepts the new line; its only proposed change is an unrelated 3.15 classifier.Review
One independent review read the commit. Its single finding said ConnectorX would mis-read the
sqlite:///C:\...URL on Windows and fail this test there. The Windows lanes above pass it on 3.10 and 3.14, so no change was made.