[hampsterx]

Summary

Fixes #424. dlt-filesystem 0.22 writes an ORC export only once PyArrow has accepted the schema (dlt-contrib/dlt-filesystem#26), so the refused write in test_orc_cannot_take_a_time_column_under_parquet_staging now leaves no file at all where it used to leave a zero-byte one.

• The test asserts that staged.orc does not exist, and drops the comment that explained the empty file.
• The dlt-filesystem floor moves to >=0.22 on the base dependency and the [filesystem] extra, so the test and the behaviour it pins ship together. The [iterable] and [vortex] extras resolve against the base floor.
• Changelog entry under "in progress".

Test plan

• On main with dlt-filesystem 0.23.0, the test fails with the FileNotFoundError from Test case test_orc_cannot_take_a_time_column_under_parquet_staging started failing #424.
• With this change: passes on dlt-filesystem 0.23.0, fails on 0.21.0 (assert not True), so the new assertion can fail.
• tests/main/filesystem/: 341 passed, 6 skipped (vortex extra not installed), Python 3.13.
• ruff format --check, ruff check, validate-pyproject clean.
• No visual effect.

Review

Two independent reviews from different model families read the commit: no findings.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 1

• coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Source mode: Auto
• Repository: panodata/omniload
• Branch: main
• File: .coderabbit.yaml
• Commit: 41aa2f5
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 67c55feb-74ad-4572-a43c-447b4fa8851b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[read-the-docs-community]

Documentation build overview

📚 omniload | 🛠️ Build #35339835 | 📁 Comparing 6bd321c against latest (41aa2f5)

  🔍 Preview build  

1 file changed

± changelog.html

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.24%. Comparing base (9f1d2fc) to head (6bd321c).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   60.11%   60.24%   +0.13%     
==========================================
  Files         201      201              
  Lines       10311    10344      +33     
==========================================
+ Hits         6198     6232      +34     
+ Misses       4113     4112       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[amotl]

Thank you!