Repository navigation
Chore: Remove an unused ty: ignore in the AppsFlyer test - #405
Conversation
- `poe lint` passes on `main` again, so the integration jobs get past lint to the test suite. ty 0.0.85 reports the `# ty: ignore[invalid-context-manager]` at `tests/warehouse/saas/test_appsflyer.py:200` as `unused-ignore-comment`, and `poe lint` fails on that warning.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
=======================================
Coverage 57.12% 57.12%
=======================================
Files 196 196
Lines 9662 9662
=======================================
Hits 5519 5519
Misses 4143 4143 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
poe lintpasses onmainagain, so the integration jobs get past lint to the test suite. ty 0.0.85 reports the# ty: ignore[invalid-context-manager]attests/warehouse/saas/test_appsflyer.py:200asunused-ignore-comment, andpoe lintfails on that warning.invalid-attribute-overrideerrors insrc/omniload/source/rsync/transport.py; this PR does not address those.Docs: none needed: no caller-visible change
Test plan
ty check(0.0.85) clean on the full tree; with the comment restored it reportsunused-ignore-commentat line 200 and exits 1ruff format --check,ruff check,validate-pyprojectclean