Skip to content

Chore: Remove an unused ty: ignore in the AppsFlyer test - #405

Merged
amotl merged 1 commit into
panodata:mainfrom
hampsterx:fix/test-appsflyer-unused-ty-ignore
Oct 16, 2026
Merged

amotl merged 1 commit into
panodata:mainfrom
hampsterx:fix/test-appsflyer-unused-ty-ignore

Conversation

@hampsterx

@hampsterx hampsterx commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • poe lint passes on main again, so the integration jobs get past lint to the test suite. ty 0.0.85 reports the # ty: ignore[invalid-context-manager] at tests/warehouse/saas/test_appsflyer.py:200 as unused-ignore-comment, and poe lint fails on that warning.
  • The open ty 0.0.88 bump (fix(deps): update dependency ty to v0.0.89 #398) reports separate invalid-attribute-override errors in src/omniload/source/rsync/transport.py; this PR does not address those.

Docs: none needed: no caller-visible change

  • No visual effect.

Test plan

  • ty check (0.0.85) clean on the full tree; with the comment restored it reports unused-ignore-comment at line 200 and exits 1
  • ruff format --check, ruff check, validate-pyproject clean

- `poe lint` passes on `main` again, so the integration jobs get past lint
  to the test suite. ty 0.0.85 reports the
  `# ty: ignore[invalid-context-manager]` at
  `tests/warehouse/saas/test_appsflyer.py:200` as `unused-ignore-comment`,
  and `poe lint` fails on that warning.
@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 1
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: panodata/omniload/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 251c0d8d-01b7-455f-86fc-526189449d11

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.12%. Comparing base (ecec70b) to head (3d204b0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   57.12%   57.12%           
=======================================
  Files         196      196           
  Lines        9662     9662           
=======================================
  Hits         5519     5519           
  Misses       4143     4143           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amotl
amotl merged commit 57065e0 into panodata:main Oct 16, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants