Fix Console schedule argument splitting to respect quoted values - #33
Open
arskinner wants to merge 1 commit into
Open
Fix Console schedule argument splitting to respect quoted values#33arskinner wants to merge 1 commit into
arskinner wants to merge 1 commit into
Conversation
explode(' ', ...) broke any argument value wrapped in quotes (e.g.
--message="hello world" split into --message="hello and world").
parseArguments() now keeps quoted spans intact as a single argument
and strips the delimiting quotes afterward.
Addresses review feedback on panlatent#28.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows up on #28, which fixed
Console::buildCommand()splitting multi-argument command strings, but used a naiveexplode(' ', $this->arguments). As noted in review on that PR, this breaks any argument value wrapped in quotes — e.g.--message="hello world" --forcegets split into--message="hello,world",--forceinstead of--message=hello world,--force.This PR replaces the plain
explode()with aparseArguments()helper that treats"..."and'...'spans as a single argument (keeping embedded spaces intact) and strips the delimiting quotes from the result.Test plan
Verified with representative inputs:
a b c→['a', 'b', 'c']--message="hello world" --force→['--message=hello world', '--force']'single quoted value' next→['single quoted value', 'next']null/ empty string →[]php -lpasses on the changed file.🤖 Generated with Claude Code