Skip to content

chore: allow grouped isort imports instead of forcing one per line - #72

Merged
SuMayaBee merged 1 commit into
mainfrom
relax-isort-force-single-line
Aug 24, 2026
Merged

SuMayaBee merged 1 commit into
mainfrom
relax-isort-force-single-line

Conversation

@SuMayaBee

Copy link
Copy Markdown
Collaborator

Description

Follow-up to review feedback on #71, which asked to collapse cli.py's imports onto fewer lines. ruff kept auto-splitting them back apart because of force-single-line = true in pyproject.toml, so that PR landed with a per-file ruff ignore as a stopgap instead.

  • Turned off force-single-line repo-wide.
  • Removed the now-redundant per-file ignore on cli.py.
  • Reformatted 24 files via ruff check --fix (no manual logic changes).

AI Disclosure

  • Tool & Model: Claude Code, Sonnet 5

  • Usage: Flipped the isort setting, ran the auto-fix, verified lint and the
    full test suite pass.

  • I have tested all AI-generated content in my PR.

  • I take responsibility for all AI-generated content in my PR.

Checklist

  • Tests added and are passing
  • Added documentation

force-single-line made every multi-name import expand to one line per
name, which is what triggered the review request on #71 to collapse
panel_live_server.install's 20+ names in cli.py (merged with a per-file
ruff ignore as a stopgap). Turning it off repo-wide lets ruff group
related imports naturally and removes the need for that ignore.
@SuMayaBee
SuMayaBee requested a review from ahuang11 August 24, 2026 16:43
@SuMayaBee
SuMayaBee merged commit f4ccaa9 into main Aug 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants