chore: lint imports that are not at the top-level of a file - #69
Merged
Merged
Conversation
Collaborator
Author
|
@ahuang11 It's ready for review, here is the detail overview:
|
ahuang11
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Turns on ruff's
PLC0415(import should be at the top level of a file), so a lazy import gets caught by lint instead of only in review. Bumps the pinned ruff pre-commit rev tov0.15.5, the rule only became stable there.Every import this flagged was already deliberately lazy, so each gets a
# noqa: PLC0415and a comment naming its measured cost.Fixes #68
AI Disclosure
Tool & Model: Claude Code
I have tested all AI-generated content in my PR.
I take responsibility for all AI-generated content in my PR.
Checklist