Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
wsgi_app, the call toresponse(environ, start_response)sits outside the innertry/exceptthat catches dispatch errors. When this call raises (for example, a streaming response body fails or the client disconnects mid-delivery), theerrorvariable remainsNone. Thefinallyblock then callsctx.pop(error)witherror=None, so allteardown_requestfunctions receiveexc=Noneinstead of the actual exception. This silently discards the error, making it impossible for teardown logic to make informed cleanup decisions (such as rolling back a database transaction versus committing).The fix wraps
response(environ, start_response)in atry/except BaseExceptionthat captures the error into theerrorvariable before re-raising. Thefinallyblock then passes the correct exception toctx.pop(error). UsingBaseExceptionensures thatKeyboardInterrupt,SystemExit, and other non-Exceptionthrowables during WSGI response delivery are also captured. The exception is always re-raised after capture — it is never swallowed or handled, preserving the existing contract thatwsgi_apppropagates unexpected errors to the WSGI server.A regression test is added that creates a
Responsesubclass whose__call__raisesRuntimeError, registers ateardown_requesthandler, and asserts that the handler receives theRuntimeErrorinstance. This test fails on the unpatched code (teardown receivesNone) and passes with the fix. The full Flask test suite (492 tests) passes with no regressions.