Strip all ANSI sequences#3681
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR augment the ANSI regexp used in Click so it can recognize and strip all ANSI sequences, including those not produced by Click itself.
I made the tests a bit exhaustive to demonstrate the lack of regression between the older naive regexp and my new proposal. But if you are convinced I can just get rid of them.
The code is based on work I produced 6 years ago and contributed to
boltons: mahmoud/boltons#258It is in line with what is done upstream in the cpython project:
Follows up on:
TextWrapperANSI-aware #3420confirm()andprompt()#3653