Repository navigation
Conversation
Packages Ubuntu's phased rollout is holding back from this machine were shown as plain "upgrade available" with no indication that "upgrade all" (dist-upgrade) won't actually touch them, since phasing applies regardless of upgrade mode. UpgradeConflicts (X) now also parses apt-get upgrade -s's "deferred due to phasing" section, alongside the existing dependency-holdback one. Addresses the remaining item reported in #9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extends the
X(Upgrade conflicts) screen in the apt backend to also detect and report packages held back by Ubuntu's phased-update rollout, not just the existing dependency-based holdbacks.Why
Feedback on #9 (post-merge testing of the Flatpak/Homebrew/MacPorts release) reported that packages deferred by Ubuntu's phased rollout showed up as plain "Upgrade available" everywhere, with no indication that neither a plain
apt-get upgradenordist-upgrade(what "Upgrade all" uses) will actually touch them until the rollout reaches that machine —apt list --upgradablelists them regardless of phasing, so pkgtui inherited the same misleading signal.Changes
internal/apt/apt.go: newparsePhasedOutput, parsing apt-get upgrade -s's "The following upgrades have been deferred due to phasing:" section;UpgradeConflicts()now reports these alongside dependency-based holdbacks, each with its own reason string. Shared indentation-parsing logic factored intoparseNamesUnderMarker.internal/apt/apt_test.go: coverage for the new parser (with and without phased packages present).README.md/docs/index.html: updated the Upgrade conflicts feature description and keybinding table to mention phased-update detection.CHANGELOG.md: new "Fixed" entry under Unreleased.Testing
go build ./...,go vet ./...,go test ./...all pass.UpgradeConflicts()against this machine's realapt-get upgrade -soutput (existing dependency-holdback packages still detected correctly); no live phased package was available locally to exercise that branch end-to-end, but the parser is covered by unit tests against apt's documented real output format.Closes the remaining feedback item on #9.