Skip to content

Expose copr runtime_dependencies#2720

Open
LecrisUT wants to merge 3 commits into
packit:mainfrom
LecrisUT:fix/2719
Open

Expose copr runtime_dependencies#2720
LecrisUT wants to merge 3 commits into
packit:mainfrom
LecrisUT:fix/2719

Conversation

@LecrisUT
Copy link
Copy Markdown
Contributor

@LecrisUT LecrisUT commented May 12, 2026

TODO:

Fixes #2719

Merge before packit.dev#TBD

RELEASE NOTES BEGIN

copr_build jobs will now configure runtime_dependencies in the copr project. By default it will use the values of
additional_repos. You may explicitly set it to an empty list or another value to opt-out.

RELEASE NOTES END

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for runtime_dependencies in Copr builds, updating the API, configuration schemas, and helper functions to handle this new field. Feedback includes a correction to the defaulting logic to ensure empty lists are handled correctly, a suggestion to add safety checks when accessing the field from Copr project objects to maintain compatibility with older client versions, and a fix for an integration test where a string was incorrectly passed instead of a list.

Comment thread packit/copr_helper.py Outdated
Comment thread packit/copr_helper.py
Comment thread tests/integration/test_copr_build.py Outdated
@centosinfra-prod-github-app
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Member

@nforro nforro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once tests are fixed.

@LecrisUT LecrisUT marked this pull request as ready for review May 19, 2026 15:51
@LecrisUT LecrisUT requested a review from a team as a code owner May 19, 2026 15:51
@LecrisUT LecrisUT requested review from lbarcziova and removed request for a team May 19, 2026 15:51
@centosinfra-prod-github-app
Copy link
Copy Markdown
Contributor

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/85d70800f28d42fc9b57228670c7dc92

✔️ pre-commit SUCCESS in 2m 20s
✔️ packit-tests-rpm SUCCESS in 20m 39s
✔️ packit-tests-pip-deps SUCCESS in 21m 26s
✔️ packit-tests-git-main SUCCESS in 20m 45s
✔️ packit-tests-pip-deps-sess-rec SUCCESS in 2m 22s
✔️ packit-tests-git-main-sess-rec SUCCESS in 2m 41s
✔️ reverse-dep-packit-service-tests SUCCESS in 4m 58s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting copr's runtime_dependencies together with additional_repositories

2 participants