Qol/faster downloads and updates - #23
Open
SuperProCoolName wants to merge 5 commits into
Open
SuperProCoolName wants to merge 5 commits into
SuperProCoolName wants to merge 5 commits into
Conversation
- download four fragments at a time (--concurrent-fragments 4), which sidesteps the per-connection throttling YouTube and HLS sites apply - keep the managed yt-dlp in ~/.yoinks/bin fresh: a silent weekly check plus an explicit `yoinks --update`. A stale binary is the usual cause of sudden "download failed"; a yt-dlp the user installed is never touched - `o` on the finished screen reveals the file in the system file manager
Private accounts, stories, age-gated videos and most Instagram posts are login-walled — yt-dlp can borrow the cookies of a browser you're already signed into. `--cookies <browser>` turns that on for both the metadata probe and the download, and sticks in ~/.config/yoinks/config.json so it only has to be typed once. The footer names the browser in use, since a remembered setting that silently logs you in should be visible, and `--cookies none` clears it.
Typing --cookies every time was the wrong default: the browser is right there, and without cookies Instagram and anything age-gated just fails. yoinks now finds an installed browser on its own (firefox first — chromium stores are encrypted on macOS and Windows) and borrows its cookies. When that browser's cookies turn out to be unreadable the run silently continues signed out, so a guess can never cost you a download that would have worked. --cookies none opts out, --cookies auto comes back. The -J metadata dump each probe writes to the temp dir was never deleted, so /tmp filled up one file per link. Runs now clean up after themselves on exit and sweep dumps older than a day left by runs that were killed.
A browser we picked ourselves was handed to yt-dlp for every link, YouTube included, and YouTube answers a signed-in-but-stale cookie jar with "The page needs to be reloaded" — for videos that download fine signed out. It rotates session cookies constantly, so a running browser's jar is usually already stale when yt-dlp reads it. Automatic sign-in now skips YouTube; --cookies <browser> still covers it, because pinning a browser is a deliberate choice and age-gated videos need one. The probe's fallback also widened: any failure with guessed cookies is retried without them, not just the ones that name the cookie store.
explorer.exe /select,<path> is meant to open the folder with the file highlighted, but on a fresh explorer session (no window opened yet) it silently ignores the flag and opens Documents instead — the path was always correct, Explorer just didn't act on it. Opening the folder directly works every time; it just can't highlight the file inside it.
Author
|
Bugfixes related to my earlier changes:
|
SuperProCoolName
marked this pull request as ready for review
September 4, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made some changes with claude
--concurrent-fragments 4- now it should download faster--cookies-from-browser firefox, now it attaches it, so for example instagram downloads some videos correctlyoand the folder should open where you downloaded video