[bazel] Modify includes for piserver#648
Conversation
Signed-off-by: c8ef <c8ef@outlook.com>
|
cc @fruffy @jafingerhut @matthewtlam for review. |
|
Also, from this bazel build run, we can see that the build cache is working well. The bazel action finished almost instantly. |
|
Gentle ping on this PR since it's a required dependency for the bmv2 bazel build~ |
FYI, I could rubber-stamp approve it, without knowing what the changes mean, as I have no knowledge of how Bazel works, but it would be better if someone with at least some knowledge of Bazel can review it. |
|
Bazel changes should be reviewed by @p4lang/google-p4-infra folks. |
There was a problem hiding this comment.
LGTM!
@c8ef Can we update the PR description regarding that we need this to expose the piserver's header files so that BMv2 can successfully build with Bazel without missing header/include errors?
4 participants
BMv2 has following use case:
https://github.com/p4lang/behavioral-model/blob/044fccf9d40b04849f9f0d9b314f63678738ec25/targets/simple_switch_grpc/switch_runner.cpp#L31
In order to support this kind of includes we need the change in this pr.