(plain) BITMAPINFOHEADER (to) support - #704
Draft
bas1licate wants to merge 34 commits into
Draft
Conversation
bas1licate
marked this pull request as draft
July 10, 2026 09:31
Contributor
|
There's a first time for everything! Thank you for the shout-out :) |
Author
|
now the reason this is staying as draft is because the code still contains a few issues i have yet to fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I may put a more thorough explanation in the issue but in "short", (plain 40-byte) BITMAPINFOHEADER is generally worth adding in my opinion. first, according to en-wikipedia for at least 15 years, this version is a common header. second, it is also very nice for learning how the bmp format works, so it has that value as well. for these reasons, i think supporting it in addition to the already-supported BITMAPINFOV5HEADER used for most if not all other conversions to BMP would be a good idea.
lastly, i would perhaps like to dedicate this pr to @omega-fallon for making rgba.ts, and also for being a super contributor to the repo in general, but honestly, who dedicates PRs?(may) Resolve #705