Open
Conversation
The goal of this change is to allow this project to be developed using dune package management, which wasn't possible before as the template project depended on a version of sihl other than the one in this repository. Admitedly it's not ideal that dune tries to include the template's dependencies in the dependency solution for this project, but a simple workaround is to remove the version constraint. Setting the version of sihl in the template project to the version of sihl current in this project (4.0.0) would also work, but removing the constraint altogether feels like less maintenance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this change is to allow this project to be developed using dune package management, which wasn't possible before as the template project depended on a version of sihl other than the one in this repository. Admitedly it's not ideal that dune tries to include the template's dependencies in the dependency solution for this project, but a simple workaround is to remove the version constraint.
Setting the version of sihl in the template project to the version of sihl current in this project (4.0.0) would also work, but removing the constraint altogether feels like less maintenance.