Repository navigation
[codegen, fix] Replace (not insert) table entries with matching keys - #282
Merged
Merged
Conversation
`HashSet::insert` retained the prev entry, which meant that adding the same key with a new action or new params was a no-op. We now use replace per @rcgoodfellow @ oxidecomputer/dendrite#405.
This was referenced Nov 7, 2026
Open
zeeshanlakhani
added a commit
to oxidecomputer/dendrite
that referenced
this pull request
Nov 9, 2026
Note on *deps*: - softnpu -> zl/table-clear (oxidecomputer/softnpu#234) - p4 -> zl/upsert-table-entries (oxidecomputer/p4#282)
zeeshanlakhani
added a commit
to oxidecomputer/softnpu
that referenced
this pull request
Nov 9, 2026
Previously, dpd could only clear tracked multicast replication entries in softnpu. The pipeline outlives the dpd process, and any state from earlier runs was not cleared. Includes: - `TableClear` empties a table under the pipeline lock (without a response) - unknown table IDs get rejected (and logged by SoftNPU). - mgmt replies (radix, `DumpRequest`) return the send error instead of unwrapping it (SoftNPU logs and continues) - p4rs pinned to oxidecomputer/p4#282. Note: propolis will drop `TableClear` requests until softnpu is updated there.
zeeshanlakhani
added a commit
to oxidecomputer/softnpu
that referenced
this pull request
Nov 9, 2026
Previously, dpd could only clear tracked multicast replication entries in softnpu. The pipeline outlives the dpd process, and any state from earlier runs was not cleared. Includes: - `TableClear` empties a table under the pipeline lock (without a response) - unknown table IDs get rejected (and logged by SoftNPU). - mgmt replies (radix, `DumpRequest`) return the send error instead of unwrapping it (SoftNPU logs and continues) - p4rs pinned to oxidecomputer/p4#282. Note: propolis will drop `TableClear` requests until softnpu is updated there.
rcgoodfellow
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HashSet::insertretained the prev entry, which meant that adding the same key with a new action or new params was a no-op. We now use replace per @rcgoodfellow @ oxidecomputer/dendrite#405.