Repository navigation
[mcast, pt3] mgd admin API + mgadm for the MRIB - #959
Open
zeeshanlakhani wants to merge 10 commits into
Open
zeeshanlakhani wants to merge 10 commits into
zeeshanlakhani wants to merge 10 commits into
Conversation
The third part of a series of recut (and properly refactored) PRs split from #675/#696. This exposes rdb MRIB access through `mg-admin` and `mgadm`. We introduce multicast support by way of a new API version, adding the following endpoints: - `GET /mrib/status/{imported,selected}` -> lists `mrib_in`/`mrib_loc` (address family + origin filters) or looks up a specific route when `group` is provided: - `(*,G)` lookup when `source` is omitted. - `(S,G)` lookup when `source` is provided. SSM requires `source`. - Note: `vni` defaults to 77. - Invalid keys result in a 400 (`MulticastRouteError`), and a miss is a 404. - `PUT|DELETE|GET /static/mroute` -> add, remove, and list static multicast routes. Includes: - `mgadm` adds new read-only commands: `mrib status imported|selected` and `static get-mroutes` for inspection. Omicron owns group membership and lifecycle, and programs routes through the API. - Handler tests, including HTTP tests for the route lifecycle through `mg-admin-client` and invalid query/body rejection. - Shared test fixtures across BGP, static-route, and MRIB setups. - `test_ctx` keeps its `TestDb` guard for the lifetime of a context. The previous setup removed the DB directory while it was still in use in the context. - `TestServer` awaits server shutdown before DB cleanup.
… mrib This change allows Omicron to enable MRIB `Arbitrary` impls through the crates it already depends on, while we have re-exports to expose the types (at latest + version).
zeeshanlakhani
force-pushed
the
zl/mcast-admin
branch
from
October 31, 2026 08:48
a3fa4ea to
3d1cac9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The third part of a series of recut (and properly refactored) PRs split from #675/#696.
This exposes rdb MRIB access through
mg-adminandmgadm. We introduce multicast support by way of a new API version, adding the following endpoints:GET /mrib/status/{imported,selected}-> listsmrib_in/mrib_loc. Every query param (group,source,vni, address family, origin) forms a logical AND combination filter, and a miss just returns an empty list.vni(77 is OPTE/omicron policy).MribQueryError).PUT|DELETE|GET /static/mroute-> add, remove, and list static multicast routes.Includes:
mgadmadds new read-only commands:mrib status imported|selectedandstatic get-mroutesfor inspection. Omicron owns group membership and lifecycle, and programs routes through the API.mg-admin-clientre-exportslatest::mrib(asmg_admin_client::mrib) and the pinnedv14module.testingfeature is forwarded throughmg-api-typesandmg-admin-client, giving way for Omicron proptests to import theArbitraryimpls from [mcast, pt1] multicast address, source, and route key types #943 without a directmg-api-types-versionsdep.mg-admin-clientand invalid query/body rejection.test_ctxkeeps itsTestDbguard for the lifetime of a context. The previous setup removed the DB directory while it was still in use in the context.TestServerawaits server shutdown before DB cleanup.